-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Move statesync_test canister to Rust CDK #2959
Conversation
Given that we ran into quite some trouble with the XNet test canister port, would it be possible to trigger all the tests that typically also run on an RC on this one? |
I have asked the team to let me know what I need to run. I have confirmed that both |
Please trigger the pipelines that usually run on an RC. My concern is that -- similar to last time -- running selective tests will make us miss some subtle connections. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. The refactoring looks good to me.
Release testing pipeline is green on latest commit. |
Thanks a lot @dsarlis for running these tests! Given that Shuo has already approved the code changes feel free to go ahead with merging right away. |
dfn_core
is considered deprecated and the plan is to eventually remove it. Therefore, we need to move any canisters in theic
repo that still depend on it to instead use the public CDK. This PR migrates thestatesync_test
canister.