fix: In order to ensure consensus passes, forex rates must be sorted. #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfinity-ryancroote
changed the title
THLO
reviewed
Nov 28, 2023
THLO
approved these changes
Nov 28, 2023
pernicat
approved these changes
Nov 28, 2023
nategurian
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of writing this description, the XRC on production has only been able to collect rates from 2 forex sources due to consensus errors. This is due to encoding a hash map to candid. The hash map does not preserve any sense of order; therefore, a b-tree map should be used as it will preserve order of the values when encoded.
This PR also adds logging into the transform so we may better see what is actually occurring during that process.