chore: adapt to the new governance list neuron pagination api #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR depends of two other PR's:
chore(deps): manual upgrade of deps #1217: currently this PR is based off of that PR's branch and it will be changed once the fix is merged toIt is now based onmainmainOnce the PR on IC repo is merged, this PR will be updated with correct versions because current versions in
Cargo.tomlare based on the latest version in said branch.Since the change in governance candid isn't a breaking change it is safe to merge this even before the governance canister is upgraded to the version that contains the change.
For our use-cases for
list_neuronsits highly unlikely we will ever need to paginate and we could've stuck with the current implementation but for the purpose of canister library fullness and no weird bugs this is added.