Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ConfigMapSecret -update form submission handlers and improve error handling in dry run #2350

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

RohitRaj011
Copy link
Contributor

@RohitRaj011 RohitRaj011 commented Jan 10, 2025

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes https://github.com/devtron-labs/sprint-tasks/issues/1675

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@RohitRaj011 RohitRaj011 self-assigned this Jan 10, 2025
@github-actions github-actions bot added the PR:Issue-verification-failed PR:Issue-verification-failed label Jan 10, 2025
@RohitRaj011 RohitRaj011 changed the base branch from develop to main January 13, 2025 04:48
@RohitRaj011 RohitRaj011 force-pushed the fix/cm-cs-dry-run-submit branch from 006cafe to 1a3080f Compare January 13, 2025 04:48
@github-actions github-actions bot added PR:Ready-to-Review PR:Ready-to-Review and removed PR:Issue-verification-failed PR:Issue-verification-failed labels Jan 13, 2025
@RohitRaj011 RohitRaj011 merged commit f996270 into main Jan 13, 2025
10 of 11 checks passed
@RohitRaj011 RohitRaj011 deleted the fix/cm-cs-dry-run-submit branch January 13, 2025 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR:Ready-to-Review PR:Ready-to-Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants