-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Revamp UI of Global Notifictaion Configuration #2318
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivani170
requested review from
vikramdevtron and
vivek-devtron
as code owners
December 26, 2024 01:20
github-actions
bot
added
the
PR:Issue-verification-failed
PR:Issue-verification-failed
label
Dec 26, 2024
RohitRaj011
requested changes
Jan 2, 2025
...Configurations/ClustersAndEnvironments/ClusterEnvironmentDrawer/ClusterEnvironmentDrawer.tsx
Outdated
Show resolved
Hide resolved
RohitRaj011
previously approved these changes
Jan 6, 2025
…-configuration-code-refactoring
Quality Gate passedIssues Measures |
9 tasks
…tion-test-case chore: Notification test case id
fix: Notification QA fixes
…labs/dashboard into feat/notification-configuration
Quality Gate passedIssues Measures |
vivek-devtron
approved these changes
Jan 13, 2025
github-actions
bot
added
PR:Ready-to-Review
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
PR:Issue-verification-failed
labels
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat: Revamp UI of Global Notifictaion Configuration
//cards are wrapped in extra div
Fixes https://github.com/devtron-labs/sprint-tasks/issues/1602
Type of change
Checklist: