Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Revamp UI of Global Notifictaion Configuration #2318

Merged
merged 56 commits into from
Jan 13, 2025

Conversation

shivani170
Copy link
Contributor

@shivani170 shivani170 commented Dec 26, 2024

Description

feat: Revamp UI of Global Notifictaion Configuration
Screenshot 2024-12-26 at 6 50 23 AM

  • App Details Deployment Status Card
  • commit/tag/pr card padding
    //cards are wrapped in extra div

Fixes https://github.com/devtron-labs/sprint-tasks/issues/1602

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@shivani170 shivani170 self-assigned this Dec 26, 2024
@github-actions github-actions bot added the PR:Issue-verification-failed PR:Issue-verification-failed label Dec 26, 2024
RohitRaj011
RohitRaj011 previously approved these changes Jan 6, 2025
Copy link

sonarqubecloud bot commented Jan 6, 2025

@shivani170 shivani170 mentioned this pull request Jan 9, 2025
9 tasks
…tion-test-case

chore: Notification test case id
@github-actions github-actions bot added PR:Ready-to-Review PR:Ready-to-Review and removed PR:Issue-verification-failed PR:Issue-verification-failed labels Jan 13, 2025
@shivani170 shivani170 merged commit aadeb7f into develop Jan 13, 2025
10 of 11 checks passed
@shivani170 shivani170 deleted the feat/notification-configuration branch January 13, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR:Ready-to-Review PR:Ready-to-Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants