Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add lock config to k8s manifest #2168

Closed
wants to merge 10 commits into from
Closed

Conversation

Elessar1802
Copy link
Contributor

Description

Screenshot 2024-11-04 at 3 39 58 PM

This feature adds FE only support of lock configuration for k8s resource manifest.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@Elessar1802 Elessar1802 marked this pull request as ready for review November 4, 2024 10:14
@Elessar1802 Elessar1802 changed the base branch from feat/manifest-gui to main November 4, 2024 11:16
@Elessar1802 Elessar1802 changed the base branch from main to feat/manifest-gui November 4, 2024 11:17
Copy link

sonarqubecloud bot commented Nov 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@Elessar1802 Elessar1802 changed the base branch from feat/manifest-gui to develop November 5, 2024 12:45
@Elessar1802 Elessar1802 dismissed eshankvaish’s stale review November 5, 2024 12:45

The base branch was changed.

@Elessar1802
Copy link
Contributor Author

Merged into kubecon-2024

@Elessar1802 Elessar1802 closed this Nov 8, 2024
@Elessar1802 Elessar1802 deleted the feat/lock-manifest branch November 15, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants