chore: restructure into a monorepo using pnpm #2140
Conversation
Elessar1802
force-pushed
the
chore/pnpm
branch
from
f370b6f to
f29ec8d
Compare
|
| @@ -0,0 +1,69 @@ | |||
| .eslintrc.cjs | |||
There was a problem hiding this comment.
- Move eslint to the top level along with these files
- What about linting for fe-lib
There was a problem hiding this comment.
Will be doing it with your guidance :)
| @@ -0,0 +1,62 @@ | |||
| { | |||
There was a problem hiding this comment.
- clean up tsconfig
- add the tsconfig at the root by extending the one from dashboard
- Check for alias at the root level
There was a problem hiding this comment.
Can't clean up tsconfig since it is coupled with vite. Any ways we use tsconfig only to check typings and never use any of the compiled code directly.
There was a problem hiding this comment.
Let's common out the tsconfig and extend each of the package
packages/devtron-fe-common-lib/src/Shared/Components/Button/Button.component.tsx
Show resolved
Hide resolved
packages/devtron-fe-common-lib/src/Shared/Components/SelectPicker/SelectPicker.component.tsx
Outdated
Show resolved
Hide resolved
Elessar1802
requested review from
vikramdevtron and
vivek-devtron
as code owners
| @@ -153,22 +152,26 @@ if (!window || !window._env_) { | |||
| SYSTEM_CONTROLLER_LISTING_TIMEOUT: 60000 * 5, | |||
| FEATURE_STEP_WISE_LOGS_ENABLE: true, | |||
| FEATURE_IMAGE_PROMOTION_ENABLE: false, | |||
| FEATURE_CD_MANDATORY_PLUGINS_ENABLE: true, | |||
There was a problem hiding this comment.
custom env is breaking
| COPY --from=builder /app/./env.sh . | ||
| COPY --from=builder /app/.env . | ||
| COPY --from=builder /app/apps/web/./env.sh . | ||
| COPY --from=builder /app/apps/web/.env . | ||
| COPY --from=builder /app/health.html . | ||
|
|
||
| RUN chown -R devtron:devtron /usr/share/nginx/html |
There was a problem hiding this comment.
Cases to be tested:
- Local: OSS / Ent
- OSS / Ent Deployed
- EA OSS / ENT Deployed
There was a problem hiding this comment.
- Dashboard CI
- Remove the deprecated action yamls
There was a problem hiding this comment.
- Removed the deprecated action yamls
- Dashboard CI
|
| storybook-static | ||
| storybook-static/ | ||
|
|
||
| pnpm-lock.yaml |
There was a problem hiding this comment.
lock file should be removed
There was a problem hiding this comment.
Add fe-lib script in dummy repo
There was a problem hiding this comment.
HMR not working for scss
There was a problem hiding this comment.
ent to OSS and OSS to ent switch back
There was a problem hiding this comment.
issue with importComponentFromFELIb in case of direct redirection
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: