clean up stack stub code from state

devsoc-unsw · Mar 10, 2024 · b0b7bdb · b0b7bdb
1 parent 51d020b
commit b0b7bdb
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 117 deletions.
diff --git a/client/src/visualiser-debugger/Component/StackInspector/StackInspector.tsx b/client/src/visualiser-debugger/Component/StackInspector/StackInspector.tsx
@@ -2,42 +2,15 @@
  * TODO: this is incomplete, horrible code
  * Need huge refactor work
  */
-import React from 'react';
 import styles from './StackInspector.module.scss';
-import { useGlobalStore } from '../../Store/globalStateStore';
 
 const StackInspector = () => {
-  const { stackInspector: debuggerData }: { stackInspector: any } = useGlobalStore().visualizer;
   return (
     <div className={styles.stackInspector}>
       <div style={{ fontSize: 'small' }}>
         Note: This is so far just a placeholder, doesn&#39;t show actual stack data from the
         debugger yet.
       </div>
-      {debuggerData.stack.map((stackFrame, idx) => (
-        <div className={styles.frame} key={idx}>
-          <div className={styles.frameHeader}>
-            <code className={styles.function}>{stackFrame.callerLocation.function}()</code>{' '}
-            <span className={styles.location}>
-              @ {stackFrame.callerLocation.file}:{stackFrame.callerLocation.line}:
-              {stackFrame.callerLocation.column}
-            </span>
-          </div>
-          <dl>
-            {stackFrame.locals.map((stackLocal) => (
-              <>
-                <dt>
-                  <code className={styles.type}>{stackLocal.type}</code>
-                  <code className={styles.name}>{stackLocal.name}</code>
-                </dt>
-                <dd>
-                  <code className={styles.value}>{stackLocal.value}</code>
-                </dd>
-              </>
-            ))}
-          </dl>
-        </div>
-      ))}
     </div>
   );
 };

diff --git a/client/src/visualiser-debugger/Store/globalStateStore.tsx b/client/src/visualiser-debugger/Store/globalStateStore.tsx
@@ -6,7 +6,6 @@ import { visualizerFactory } from '../Component/Visualizer/Visulizer/visualizerF
 import { UserAnnotation } from '../Types/annotationType';
 import { BackendState, BackendTypeDeclaration, INITIAL_BACKEND_STATE } from '../Types/backendType';
 import { VisualizerType } from '../Types/visualizerType';
-import * as InspectorDummy from './stackInpsectorDummyData.json';
 
 export type UiState = {
   width: number;
@@ -19,7 +18,6 @@ export type VisualizerParam = {
   visComponent: VisualizerComponent;
   parser: Parser;
   typeDeclarations: BackendTypeDeclaration[];
-  stackInspector: any;
 };
 
 export type GlobalStateStore = {
@@ -43,7 +41,6 @@ export const DEFAULT_GLOBAL_STORE: GlobalStateStore = {
     visComponent: visualizerFactory(VisualizerType.LINKED_LIST),
     parser: parserFactory(VisualizerType.LINKED_LIST),
     typeDeclarations: [],
-    stackInspector: InspectorDummy,
   },
   currFrame: INITIAL_BACKEND_STATE,
 };

diff --git a/client/src/visualiser-debugger/Store/stackInpsectorDummyData.json b/client/src/visualiser-debugger/Store/stackInpsectorDummyData.json
diff --git a/client/src/visualiser-debugger/Store/visualizerStateStore.ts b/client/src/visualiser-debugger/Store/visualizerStateStore.ts
@@ -1,7 +1,5 @@
 import { UseBoundStore, StoreApi, create } from 'zustand';
-import { VisualizerComponent } from '../Component/Visualizer/Visulizer/visualizer';
 import { GenericGraph, INITIAL_GRAPH } from '../Types/frontendType';
-import { GlobalStateStore } from './globalStateStore';
 
 type State = {
   states: GenericGraph[];
@@ -10,8 +8,8 @@ type State = {
 };
 type Action = {
   newState: (newState: GenericGraph) => void;
-  nextState: () => void;
-  lastState: () => void;
+  setNextState: () => void;
+  setLastState: () => void;
 };
 
 export const useFrontendStateStore: UseBoundStore<StoreApi<State & Action>> = create<
@@ -31,7 +29,7 @@ export const useFrontendStateStore: UseBoundStore<StoreApi<State & Action>> = cr
       currStateIdx: state.currStateIdx + 1,
     }));
   },
-  nextState: () => {
+  setNextState: () => {
     if (
       useFrontendStateStore.getState().currStateIdx >=
       useFrontendStateStore.getState().states.length - 1
@@ -42,7 +40,7 @@ export const useFrontendStateStore: UseBoundStore<StoreApi<State & Action>> = cr
       currStateIdx: state.currStateIdx + 1,
     }));
   },
-  lastState: () => {
+  setLastState: () => {
     if (useFrontendStateStore.getState().currStateIdx <= 0) {
       return;
     }
@@ -51,12 +49,3 @@ export const useFrontendStateStore: UseBoundStore<StoreApi<State & Action>> = cr
     }));
   },
 }));
-
-export interface StateManagerProp {
-  state: GenericGraph;
-  settings: GlobalStateStore;
-  setSettings: React.Dispatch<React.SetStateAction<GlobalStateStore>>;
-  nextState: () => void;
-
-  Visualizer: VisualizerComponent;
-}