Fix scraper for 2025T1 #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lhvy
commented
Dec 22, 2024
lhvy
commented
- Fix bug where courses are included in all visible careers for a given subject area
- Re-scrape data for 2025T1
lhvy
commented
Dec 22, 2024
| .expect("Expected career to be inside td element") | ||
| .next_sibling() | ||
| .expect("Expected career classes td element to come after careers") | ||
| .next_sibling() |
There was a problem hiding this comment.
I don't understand why I need two calls to next_sibling here. The middle element seems to be just a couple new lines when I debug print .value(). I've attached the HTML, maybe someone else can work out what is going on here.
Rayahhhmed
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.