feat(drawer): add name to room card #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
agnesclemente
commented
Nov 8, 2023
agnesclemente
commented
- add room name and arrow icon to room cards in building drawer
francojreyes
added a commit
that referenced
this pull request
Nov 17, 2023
* feat: update docs (#400) * feat(docs): update docs to reflect v2 * feat(docs): add setup guides for be/fe/app * feat(backend): create and adopt `/api/rooms` endpoint for room data (#401) * create `/api/rooms` endpoint for room data * Remove name and flatten data in bookings endpoint * Use new endpoints on room page * Add rooms to search modal * feat: use common folder for shared code (e.g. data types) (#402) * chore: fix cd * chore: fix backend.dockerfile * feat: integrate with CSESoc GraphQL API (#403) * Rewrite backend to use Hasura instead of timetable API * Use additional data in frontend * Please the linter * Please the type checks * Show buildings before status is loaded * Add correct GraphQL endpoint * New Building images * fix: fix broken filters with new data * feat: add filter for whether ID is required * New Building images * add name to room card and reformat status (#407) * feat(browse): building cards mobile view and height adjustment (#408) * added mobile view + breakpoint height adjustment * changed indentation style * updated cardList to use theme breakpoint --------- Co-authored-by: CHUN Nicole Wai Yan <[email protected]> * feat(drawer): add name to room card (#409) * add name to room card and reformat status * add room name to frontend room cards * building drawer styling * fix: import fonts * fix: reduce font weights of room box subheading * feat(frontend): revamped landing page (#414) * feat(hero): implement new design * fix(hero): change hero panel to svg * chore(landing): add todos to mark content additions * add descriptions for features * allow features to have either link or onclick action * Make the timetable feature open the search bar * Change tagline * feat(dynamic image): responsive image in landing page * fix(image): change hero panel mobile version * fix(margins): fix landing page margins between sections mobile version * feat(hero): implement new design * fix(hero): change hero panel to svg * chore(landing): add todos to mark content additions * add descriptions for features * allow features to have either link or onclick action * Make the timetable feature open the search bar * Change tagline * feat(dynamic image): responsive image in landing page * fix(image): change hero panel mobile version * fix(margins): fix landing page margins between sections mobile version * fix(hero): fix line spacing * fix(images): all image imports removed * fix(faq): accordion alignment fixed * fix(pipeline): ran pnpm * Small styling fixes * Write the FAQs * Correct minutes --------- Co-authored-by: Franco Reyes <[email protected]> * fix(landing): correct feature vector paths * feat(frontend): room page details (#413) * Added ( static ) room information to page and booking and photos button * created static room page from design * ran next lint * addded max width to page container * reduced image height * moved 'move photos' button closer to bottom right edge * chore(renovate): unignore frontend, target dev branch * used MUI's menu as container for Room info * contained action buttons within menu drop down when on mobile view * set room image to building image * removed 'add photo' and 'more photos' button * Changed Booking Button to go to link depending on room details * added modal for rooms managed by schools * added School type * Added school to details mapping * added getSchoolDetails function * added translateUsage function and formatted booking dialog content * removed unused code * removed unused code and packages * used lint * added types for Schools * Small styling fixes * call LIB rooms "Library Study Room" --------- Co-authored-by: Franco Reyes <[email protected]> Co-authored-by: Franco Reyes <[email protected]> * feat: change how Available Soon is displayed --------- Co-authored-by: 3bobchen <[email protected]> Co-authored-by: agnesclemente <[email protected]> Co-authored-by: Nicole Chun <[email protected]> Co-authored-by: CHUN Nicole Wai Yan <[email protected]> Co-authored-by: ur-ja <[email protected]> Co-authored-by: Alec Tan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.