Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Landing Screen Redesign #35

Merged
merged 13 commits into from
Jan 23, 2025
Merged

Landing Screen Redesign #35

merged 13 commits into from
Jan 23, 2025

Conversation

TAS-scorchedshadow
Copy link
Collaborator

Replace event carousel with more generic image carousel

@TAS-scorchedshadow TAS-scorchedshadow changed the title Landing Screen Redesign Draft: Landing Screen Redesign Jan 16, 2025
@TAS-scorchedshadow TAS-scorchedshadow marked this pull request as draft January 16, 2025 12:32
@asssssssley
Copy link

Things to look into:

  • make image section smaller
  • change opacity of images/add a black div beneath
  • arrow margin top and bottom
  • move arrow to the right
  • change "UNSW's software development society" to "UNSW Software Development Society"

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jan 18, 2025 •
edited
Loading

Deploying devsoc-website with  Cloudflare Pages  Cloudflare Pages

Latest commit: 212df5f
Status: ✅  Deploy successful!
Preview URL: https://c7c91a59.devsoc-website.pages.dev
Branch Preview URL: https://redesign-frontpage.devsoc-website.pages.dev

View logs

@TAS-scorchedshadow TAS-scorchedshadow marked this pull request as ready for review January 20, 2025 03:17
@TAS-scorchedshadow TAS-scorchedshadow changed the title Draft: Landing Screen Redesign Landing Screen Redesign Jan 20, 2025
jadekam16
jadekam16 reviewed Jan 22, 2025
View reviewed changes
Copy link

@jadekam16 jadekam16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General Feedback

  • Is it possible to lessen the delay on the carousel? Feels a little like I have to wait a long time for it to switch to the next slide
  • Nitpicking but are you able to find better background img for notangles and unilectives slides?

@TAS-scorchedshadow
Copy link
Collaborator Author

General Feedback

  • Is it possible to lessen the delay on the carousel? Feels a little like I have to wait a long time for it to switch to the next slide
  • Nitpicking but are you able to find better background img for notangles and unilectives slides?

Thinking of dropping the delay 0.5s. Not sure if its still too slow. If you want to have a play with the delay its ln15 of CustomCarousel

Are there any screens you had in mind? I can try the landing pages instead?

@jadekam16
Copy link

General Feedback

  • Is it possible to lessen the delay on the carousel? Feels a little like I have to wait a long time for it to switch to the next slide
  • Nitpicking but are you able to find better background img for notangles and unilectives slides?

Thinking of dropping the delay 0.5s. Not sure if its still too slow. If you want to have a play with the delay its ln15 of CustomCarousel

Are there any screens you had in mind? I can try the landing pages instead?

yup i think it's better now 👍 and yeah, landing pages might be better :D

@TAS-scorchedshadow
Copy link
Collaborator Author

Ready for 2nd review, the arrow suggestion is good. Happy to do in future PR, want to remove the old events soon since oweek is coming up

jadekam16
jadekam16 reviewed Jan 23, 2025
View reviewed changes
app/page.tsx
fontWeight={500}
component="div"
>
UNSW's Software Development Society
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait did you want to change it to UNSW instead of UNSW's? I think Ashley already said it somewhere

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to just do in next PR though if u wanna just merge this :D

@jadekam16
Copy link

Left one comment but otherwise lgtm 👍

@TAS-scorchedshadow TAS-scorchedshadow merged commit a4186d9 into main Jan 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jadekam16 jadekam16 jadekam16 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TAS-scorchedshadow @asssssssley @jadekam16