Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix[THKV-110]: Typography variants 수정 #99

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Fix[THKV-110]: Typography variants 수정 #99

merged 1 commit into from
Jan 7, 2025

Conversation

plla2
Copy link
Contributor

@plla2 plla2 commented Jan 7, 2025

유형

  • 기능 구현
  • UI 구현
  • 리팩토링
  • 버그 해결
  • 문서 업데이트
  • 기타( )

작업 내용

  • Typography variants 디자인 시스템에 맞게 수정

설명 (선택)

리뷰 요구사항

  • 같은 type에도 다른 text color가 생길 것 같아 color까지 variant에서 선택하게 했습니다.
  • 컴포넌트 수정하시면서 customTypography함수로 Typography 생성하실 때
AS-IS

export const HeadPrimary = customTypography('h1', {
  type: 'heading1',
  color: 'dark',
  weight: 'bold',
});
TO-BE

export const HeadPrimary = customTypography('h1', {
  type: 'H1',
  color: 'dark',
});

위와 같이 weight는 제외하고, 사용하시면 됩니다!
default color가 dark이기 때문에 dark일경우는 color제외하셔도 무방합니다~!

Copy link
Contributor

@grapefruit13 grapefruit13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@plla2 plla2 merged commit 509a20a into dev Jan 7, 2025
1 check passed
@plla2 plla2 deleted the THKV-110 branch January 7, 2025 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants