-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert adding all potential filenames inside renovate ignorePaths #278
Conversation
Singed-off-by: thepetk <[email protected]> Signed-off-by: thepetk <[email protected]>
40c55b3
to
d9fd91d
Compare
Signed-off-by: thepetk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michael-valdron, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@thepetk The fix did not work 🤔
I suspect this might be a bug with renovate if the docs are up to date, should work like I'll investigate if there is a bug report for this and open one if there is not. We could revert the additional devfile ignores to not exclude |
Update: No bug reported for this, the GitHub issue tracker for renovate does not let the community to report bugs though. |
@michael-valdron I suspect the PRs might have been flagged or something. I believe the current config is ok, so Id wait the next run and see how renovate behaves. |
Singed-off-by: thepetk [email protected]
What does this PR do?:
This PR reverts the addition of the
.devfile.yml
,devfile.yaml
&devfile.yml
names into theignoredPaths
config variable of the renovate.json file. At the moment the renovate bot autocloses all opened PRs againstdevfile.yaml
files. As a result, in order to keep active the automation (until a proper solution is found) we should remove thedevfile.yaml
names from the variable.The most suitable solution would be to add the
.devfile.yaml
(e.g.devfile/.devfile.yaml
).Which issue(s) this PR fixes:
N/A
PR acceptance criteria:
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
How to test changes / Special notes to the reviewer: