Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert adding all potential filenames inside renovate ignorePaths #278

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

thepetk
Copy link
Contributor

@thepetk thepetk commented Jan 14, 2024

Singed-off-by: thepetk [email protected]

What does this PR do?:

This PR reverts the addition of the .devfile.yml, devfile.yaml & devfile.yml names into the ignoredPaths config variable of the renovate.json file. At the moment the renovate bot autocloses all opened PRs against devfile.yaml files. As a result, in order to keep active the automation (until a proper solution is found) we should remove the devfile.yaml names from the variable.

The most suitable solution would be to add the .devfile.yaml (e.g. devfile/.devfile.yaml).

Which issue(s) this PR fixes:

N/A

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?
  • Check Tools Provider
    Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

@thepetk thepetk self-assigned this Jan 14, 2024
@thepetk thepetk force-pushed the ft/disable_pr_autoclose branch from 40c55b3 to d9fd91d Compare January 14, 2024 13:18
renovate.json Outdated Show resolved Hide resolved
Signed-off-by: thepetk <[email protected]>
Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Jan 16, 2024
Copy link

openshift-ci bot commented Jan 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michael-valdron, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [michael-valdron,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thepetk thepetk merged commit 7abb495 into devfile:main Jan 16, 2024
9 checks passed
@michael-valdron
Copy link
Member

@thepetk The fix did not work 🤔

I suspect this might be a bug with renovate if the docs are up to date, should work like .gitignore: https://docs.renovatebot.com/configuration-options/#ignorepaths

I'll investigate if there is a bug report for this and open one if there is not.

We could revert the additional devfile ignores to not exclude devfile.yaml entries but I strongly feel in the long term this should be fixed if we are to support proper devfile file paths.

@michael-valdron
Copy link
Member

I'll investigate if there is a bug report for this and open one if there is not.

Update: No bug reported for this, the GitHub issue tracker for renovate does not let the community to report bugs though.

@thepetk
Copy link
Contributor Author

thepetk commented Jan 16, 2024

@michael-valdron I suspect the PRs might have been flagged or something. I believe the current config is ok, so Id wait the next run and see how renovate behaves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Looks good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants