Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert updates to renovate.json #263

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Revert updates to renovate.json #263

merged 1 commit into from
Dec 18, 2023

Conversation

thepetk
Copy link
Contributor

@thepetk thepetk commented Dec 15, 2023

What does this PR do?:

This PR reverts all updates into the renovate.json file in order to prevent the bot from automerging the automatically created PRs in order to update the image tags used inside devfiles. Example PRs that have been automatically merged:

In order to bring back the changes introduced here: #240 we should confirm that the bot does not automerge the PRs.

Which issue(s) this PR fixes:

N/A

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?
  • Check Tools Provider
    Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

@thepetk thepetk changed the title Revert updates to renovate.json and stack images Revert updates to renovate.json Dec 15, 2023
Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Dec 18, 2023
Copy link

openshift-ci bot commented Dec 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michael-valdron, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [michael-valdron,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thepetk thepetk merged commit 85ae7ea into devfile:main Dec 18, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Looks good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants