Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove dummy caBundle from CRDs #1326

Merged
merged 2 commits into from
Oct 11, 2024
Merged

fix: remove dummy caBundle from CRDs #1326

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58e8d6c
fix: remove dummy caBundle from CRDs
dkwon17 Oct 10, 2024
94d5feb
Remove commented-out caBundle field
dkwon17 Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion deploy/bundle/manifests/workspace.devfile.io_devworkspaces.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion deploy/bundle/manifests/workspace.devfile.io_devworkspacetemplates.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions deploy/deployment/kubernetes/combined.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion ...yment/kubernetes/objects/devworkspaces.workspace.devfile.io.CustomResourceDefinition.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion ...bernetes/objects/devworkspacetemplates.workspace.devfile.io.CustomResourceDefinition.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions deploy/deployment/openshift/combined.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion ...oyment/openshift/objects/devworkspaces.workspace.devfile.io.CustomResourceDefinition.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion ...penshift/objects/devworkspacetemplates.workspace.devfile.io.CustomResourceDefinition.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions deploy/templates/cert-manager/crd_webhooks_patch.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ spec:
path: /convert
port: 443
# caBundle will be filled by cert-manager on creation
caBundle: Cg==
# caBundle: Cg==
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should just remove this line (as well as the other mentions of caBundle: Cg== from the templates) rather than commenting it out?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed them in my latest commit

---
# Add webhooks to the devfile/api CRDs
apiVersion: apiextensions.k8s.io/v1
Expand All @@ -38,4 +38,4 @@ spec:
path: /convert
port: 443
# caBundle will be filled by cert-manager on creation
caBundle: Cg==
# caBundle: Cg==
4 changes: 2 additions & 2 deletions deploy/templates/olm/crd_webhooks_patch.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ spec:
path: /convert
port: 443
# caBundle will be filled by Service CA operator
caBundle: Cg==
# caBundle: Cg==
---
# Add webhooks to the devfile/api CRDs
apiVersion: apiextensions.k8s.io/v1
Expand All @@ -34,4 +34,4 @@ spec:
path: /convert
port: 443
# caBundle will be filled by Service CA operator
caBundle: Cg==
# caBundle: Cg==
4 changes: 2 additions & 2 deletions deploy/templates/service-ca/crd_webhooks_patch.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ spec:
path: /convert
port: 443
# caBundle will be filled by Service CA operator
caBundle: Cg==
# caBundle: Cg==
---
# Add webhooks to the devfile/api CRDs
apiVersion: apiextensions.k8s.io/v1
Expand All @@ -38,4 +38,4 @@ spec:
path: /convert
port: 443
# caBundle will be filled by Service CA operator
caBundle: Cg==
# caBundle: Cg==
Loading