-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply black -l 79
and do some code cleanup
#22
Conversation
Oh and this is the first part of the code style discussion in #18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer the artisanal formatting a little more but removing coding style from the table altogether is priceless.
@cecton would you like to review? |
We should probably release soon after this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for that weird inconsistency about self
vs cls
and the author in setup.py I think it's great!
I just remember there is another project linked to this one that could be moved to the same organization. I will do that later.
_mimes = ["application/x-xz"] | ||
_extensions = ["xz"] | ||
_command = "unxz -c".split() | ||
_compression = "xz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what logic I used for the prefix with _
. It might be worth revisiting this in a different ticket
This is one time
black -l 79
for the whole codebase without setting up any automatic tools (which we'll have to discuss and evaluate and agree on).I also wanted to apply
isort
, but then following error came:so we're going to do it without
isort
now and then replace thefrom x import *
with some more explicit import that will prevent such problems.And then I did some code cleanup.