More mathspeak and ARIA clean-up #312
Conversation
First, adds the aria-hidden attribute to any focusable mQ's mathspeak region so that screen readers don't double-report the content, e.g. when the field is used as a column header. Second, empties the content of the math field's internal ARIA alert element when the field loses focus. Helps with the first problem above, but is something we should have been doing anyway.
sclower
requested review from
a team and
jared-hughes
and removed request for
a team
| @@ -93,8 +93,9 @@ class Aria { | |||
| return this.clear(); | |||
| } | |||
|
|
|||
| clear() { | |||
| clear(opts?: { emptyContent: boolean }) { | |||
There was a problem hiding this comment.
It would help to have some documentation here (and on updateMathspeak) about when a consumer would pass in emptyContent: true or not. Judging by the PR message, it sounds like we want to pass in emptyContent: true when the clear is due to a blur.
Why do we not want to pass emptyContent: true for non-blur clearing?
There was a problem hiding this comment.
@jared-hughes I've added some comments in both source files to hopefully clarify the intent of the clearContent flag.
There are two reasons why we empty the alert queue but leave the DOM in tact. The first is literally because any queued messages may no longer be relevant. The second is that, while the field has focus, we want to minimize the amount of updates to the alert element to reduce the chance that something important might not be communicated to the user. Admittedly, I haven't seen this latter case in years, but it's been known to happen.
First, adds the aria-hidden attribute to any focusable mQ's mathspeak region so that screen readers don't double-report the content, e.g. when the field is used as a table column header.
Second, empties the content of the math field's internal ARIA alert element when the field loses focus. Helps with the first problem above, but is something we should have been doing anyway.