Upgrade prettier to 3.2 #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
script/screenshots.js
Outdated
| @@ -242,7 +245,7 @@ browsers.forEach(function (browser) { | |||
| console.log( | |||
| 'ERROR:', | |||
| browser.config.browserName, | |||
| browser.config.platform | |||
| browser.config.platform, | |||
There was a problem hiding this comment.
I don't know what's going on here, but this feels like prettier is making the wrong decision.
There was a problem hiding this comment.
ohh good catch, I think we turned that rule off in our main prettierrc on knox but I didn't do it here.
There was a problem hiding this comment.
Looking here it does seem like it's configurable:
https://stackoverflow.com/a/61370655
Someone mentions the rationale behind this is version control working better with trailing commas. I don't have a strong opinion. I think it's best to just match whatever knox does if we've already made a decision there.
There was a problem hiding this comment.
Yep.. rebased the first commit to do that and match knox config exactly
timstallmann
force-pushed
the
tim/upgrade-prettier
branch
from
c96db0f to
5b98e19
Compare
mikehaverstock
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades prettier to version 3.2 (which is what we use on knox as well). Adds the commit which reformats files to git-blame-ignore-revs.