Update matching routines to check input arrays for duplicates #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! |
|
For the record, this PR looks good to me (I use the matching functionality quite extensively). Quick request: can a new tag be created after this PR (or soon after, in case there's some other stuff in progress)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #811.
@araichoor: In the end I used your suggested approach, utilizing
np.count_nonzero(), in full. I tested a bunch of corner cases and I think your approach always returns the desired result. And it is very fast!I also agree with @araichoor that it's actually desirable to break backwards compatibility in this case, as the results without checking for duplicates are essentially garbage.