Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change required signer counts for scripts #355

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

Hd0702
Copy link
Contributor

@Hd0702 Hd0702 commented Oct 4, 2024

Summary

Describe the changes made in your pull request here.

Details

Any implementation detail worth pointing out, if any.

Todo

Breakdown the progress of the PR for everyone to see what else you intend to include in this PR.

(Examples:)

  • Draft implementation for function
  • Unit tests for function
  • Gas optimization for function

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Add natspec for all functions / parameters
  • Ran forge snapshot
  • Ran forge fmt
  • Ran forge test
  • Triage Slither issues, and post uncertain ones in the PR
  • 100% test coverage on code changes

Slither Issues (Optional)

If you're unsure about a new issue reported by Slither, copy them here so others can verify as well.

@joshpwrk joshpwrk merged commit d69b557 into master Oct 4, 2024
2 checks passed
@joshpwrk joshpwrk deleted the fix/change-required-signer-count branch October 4, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants