Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Will limit any sort of unexpected results in the perp marking.
There can be potential exploit if you have some very long dated options (i.e. 2 year+) and interest rates are high, so adding a cap to ensure that cannot happen
You run into issues around cash (i.e. funding) changing the account making it hard to actually compute the max_f properly. Means we can remove tracking "percentLiquidated" and everything is just done based on the current portfolio (no reliance on previous steps). Simplifies the logic a bit which is nice.
Reasoning is: we were already blocking anything but cash. As the user getting liquidated you can liquidate your portfolio yourself -> merge to get the same effect as adding cash up to BM. You would also lose more money by donating to your portfolio and not ending auction rather than bidding on the portfolio