Lightshift - Rust precompile #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshpwrk
reviewed
Oct 2, 2024
precompiles/src/black76.rs
Outdated
| } | ||
|
|
||
| let (exponent, expiry_sec, discount, vol, fwd, strike) = extract_arguments(args); | ||
| // println!("EXPONENT {} | EXPIRY_SEC {} | DISCOUNT {} | VOL {} | FWD {} | STRIKE {}", exponent, expiry_sec, discount, vol, fwd, strike); |
There was a problem hiding this comment.
can remove this plus bunch of other comments in this file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the implementation of Black 76 precompile in Rust for Geth. This uses Lyra's implementation of Black 76 in Rust, in the cockpit repo.
Using the previous tests for the Solidity implementation, it is within acceptable margin of errors. The deviations are mainly due to the fact that the input values (in bytes) are integer, which need to be translated into floats to be able to use the third-party Rust packages.
The return values instead of being 256 bit unsigned integers, like the Solidity implementation, are 128 bit unsigned integers due to the Rust limits.
After benchmarking, we estimated that the gas cost for running this precompile is around 300. This was done by using the benchmark utility of Go and looking at the average
mgas/sof the other precompiles. You can find our findings below:Existing precompile benchmarks
Black 76 precompile benchmark
