Filebrowser #3053
Open
Filebrowser #3053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derailed
requested changes
Jan 20, 2025
|
|
||
| // It would be better to list files here ? | ||
| // No access to view/exec.go, though | ||
| txt, ok := ctx.Value(internal.KeyContents).(string) |
There was a problem hiding this comment.
Agreed! Not keen on stuffing the dir contents into the context. Best if it worked like local list. I think we should have a util call to list out dir content on a pod. If the container is not specified, we can use the main container.
| if name == "../" && dir == "/" { | ||
| continue | ||
| } | ||
| //if strings.HasSuffix(name, "/") { // directory |
| return d.transferCmd(evt) | ||
| } | ||
|
|
||
| /* |
| } | ||
|
|
||
| /* | ||
| v := NewDirRemote(d.fqn, d.co, d.os, dir, str) |
| Retries: defaultTxRetries, | ||
| Cancel: func() {}, | ||
| } | ||
| dialog.ShowUploads(d.App().Styles.Dialog(), d.App().Content.Pages, opts) |
There was a problem hiding this comment.
I think we should have a base transfer dialog for this. Based on the context aka loca/remote the Download toggle does not mean much anymore and we already know what kind of action should take place ie remote->download local->upload.
Also not keen on the view titles ie Dirlocal or Dirremote perhaps something like Local File System and Remote File System could be more comprehensible??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browse container or local files and upload or download selected file or directory.
Pressing 'B' in pod or container view opens a remote file list.
'T' or Space in remote file list downloads the file or directory.
Pressing 'L' in remote file list opens a local file list.
'T' or Space in local file list uploads the file or directory to the previously selected remote directory.