Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(argo-rollouts plugin): resolve improper piping in watch command #3009

Merged
merged 1 commit into from
Dec 7, 2024
Merged

fix(argo-rollouts plugin): resolve improper piping in watch command #3009

merged 1 commit into from
Dec 7, 2024

Conversation

davefu113
Copy link
Contributor

The -w or --watch flag is designed for continuous monitoring and should not pipe to less to avoid unnecessary screen rolling.

@davefu113
fix(argo-rollouts plugin): resolve improper piping in watch command
1a91079 
The `-w` or `--watch` flag is designed for continuous monitoring
and should not pipe to `less` to avoid unnecessary screen rolling.
derailed
derailed approved these changes Dec 7, 2024
View reviewed changes
Copy link
Owner

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davefu113 Good catch!

@derailed derailed merged commit 7230fdb into derailed:master Dec 7, 2024
4 checks passed
lacroixthomas pushed a commit to lacroixthomas/k9s that referenced this pull request Jan 15, 2025
@davefu113 @lacroixthomas
fix(argo-rollouts plugin): resolve improper piping in watch command (d…
9ce8088 
…erailed#3009)

The `-w` or `--watch` flag is designed for continuous monitoring
and should not pipe to `less` to avoid unnecessary screen rolling.

chore(deps): bump github.com/anchore/grype from 0.84.0 to 0.85.0 (derailed#3008)

Bumps [github.com/anchore/grype](https://github.com/anchore/grype) from 0.84.0 to 0.85.0.
- [Release notes](https://github.com/anchore/grype/releases)
- [Changelog](https://github.com/anchore/grype/blob/main/.goreleaser.yaml)
- [Commits](anchore/grype@v0.84.0...v0.85.0)

---
updated-dependencies:
- dependency-name: github.com/anchore/grype
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore(deps): bump k8s.io/kubectl from 0.31.1 to 0.31.3 (derailed#3007)

Bumps [k8s.io/kubectl](https://github.com/kubernetes/kubectl) from 0.31.1 to 0.31.3.
- [Commits](kubernetes/kubectl@v0.31.1...v0.31.3)

---
updated-dependencies:
- dependency-name: k8s.io/kubectl
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore(deps): bump helm.sh/helm/v3 from 3.16.2 to 3.16.3 (derailed#3006)

Bumps [helm.sh/helm/v3](https://github.com/helm/helm) from 3.16.2 to 3.16.3.
- [Release notes](https://github.com/helm/helm/releases)
- [Commits](helm/helm@v3.16.2...v3.16.3)

---
updated-dependencies:
- dependency-name: helm.sh/helm/v3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

feat: Adding new config for workload view

feat: Add config and add some documentation

feat: Refactor getValidity

feat: Refactor getValidity

feat: refactor the get replicas complexity

feat: trigger pipeline

feat: refactor workload list

feat: delete log

feat: unblock unit tests (will come back to it)

feat: fix unit tests and add k9s.json new schema

feat: add comment on the dao/workload

feat: remove todo

feat: add header on new file

feat: add new view with crud for custom gvr and rollback config

feat: add comments and flashing errors

feat: add comments

feat: update readme

feat: add comments

feat: cleanup cluster context

feat: update order of actions

feat: fix unit test
lacroixthomas pushed a commit to lacroixthomas/k9s that referenced this pull request Jan 15, 2025
@davefu113 @lacroixthomas
fix(argo-rollouts plugin): resolve improper piping in watch command (d…
3cd2f3a 
…erailed#3009)

The `-w` or `--watch` flag is designed for continuous monitoring
and should not pipe to `less` to avoid unnecessary screen rolling.

chore(deps): bump github.com/anchore/grype from 0.84.0 to 0.85.0 (derailed#3008)

Bumps [github.com/anchore/grype](https://github.com/anchore/grype) from 0.84.0 to 0.85.0.
- [Release notes](https://github.com/anchore/grype/releases)
- [Changelog](https://github.com/anchore/grype/blob/main/.goreleaser.yaml)
- [Commits](anchore/grype@v0.84.0...v0.85.0)

---
updated-dependencies:
- dependency-name: github.com/anchore/grype
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore(deps): bump k8s.io/kubectl from 0.31.1 to 0.31.3 (derailed#3007)

Bumps [k8s.io/kubectl](https://github.com/kubernetes/kubectl) from 0.31.1 to 0.31.3.
- [Commits](kubernetes/kubectl@v0.31.1...v0.31.3)

---
updated-dependencies:
- dependency-name: k8s.io/kubectl
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore(deps): bump helm.sh/helm/v3 from 3.16.2 to 3.16.3 (derailed#3006)

Bumps [helm.sh/helm/v3](https://github.com/helm/helm) from 3.16.2 to 3.16.3.
- [Release notes](https://github.com/helm/helm/releases)
- [Commits](helm/helm@v3.16.2...v3.16.3)

---
updated-dependencies:
- dependency-name: helm.sh/helm/v3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

feat: Adding new config for workload view

feat: Add config and add some documentation

feat: Refactor getValidity

feat: Refactor getValidity

feat: refactor the get replicas complexity

feat: trigger pipeline

feat: refactor workload list

feat: delete log

feat: unblock unit tests (will come back to it)

feat: fix unit tests and add k9s.json new schema

feat: add comment on the dao/workload

feat: remove todo

feat: add header on new file

feat: add new view with crud for custom gvr and rollback config

feat: add comments and flashing errors

feat: add comments

feat: update readme

feat: add comments

feat: cleanup cluster context

feat: update order of actions

feat: fix unit test
lacroixthomas pushed a commit to lacroixthomas/k9s that referenced this pull request Jan 15, 2025
@davefu113 @lacroixthomas
fix(argo-rollouts plugin): resolve improper piping in watch command (d…
c905d02 
…erailed#3009)

The `-w` or `--watch` flag is designed for continuous monitoring
and should not pipe to `less` to avoid unnecessary screen rolling.

chore(deps): bump github.com/anchore/grype from 0.84.0 to 0.85.0 (derailed#3008)

Bumps [github.com/anchore/grype](https://github.com/anchore/grype) from 0.84.0 to 0.85.0.
- [Release notes](https://github.com/anchore/grype/releases)
- [Changelog](https://github.com/anchore/grype/blob/main/.goreleaser.yaml)
- [Commits](anchore/grype@v0.84.0...v0.85.0)

---
updated-dependencies:
- dependency-name: github.com/anchore/grype
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore(deps): bump k8s.io/kubectl from 0.31.1 to 0.31.3 (derailed#3007)

Bumps [k8s.io/kubectl](https://github.com/kubernetes/kubectl) from 0.31.1 to 0.31.3.
- [Commits](kubernetes/kubectl@v0.31.1...v0.31.3)

---
updated-dependencies:
- dependency-name: k8s.io/kubectl
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore(deps): bump helm.sh/helm/v3 from 3.16.2 to 3.16.3 (derailed#3006)

Bumps [helm.sh/helm/v3](https://github.com/helm/helm) from 3.16.2 to 3.16.3.
- [Release notes](https://github.com/helm/helm/releases)
- [Commits](helm/helm@v3.16.2...v3.16.3)

---
updated-dependencies:
- dependency-name: helm.sh/helm/v3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

feat: Adding new config for workload view

feat: Add config and add some documentation

feat: Refactor getValidity

feat: Refactor getValidity

feat: refactor the get replicas complexity

feat: trigger pipeline

feat: refactor workload list

feat: delete log

feat: unblock unit tests (will come back to it)

feat: fix unit tests and add k9s.json new schema

feat: add comment on the dao/workload

feat: remove todo

feat: add header on new file

feat: add new view with crud for custom gvr and rollback config

feat: add comments and flashing errors

feat: add comments

feat: update readme

feat: add comments

feat: cleanup cluster context

feat: update order of actions

feat: fix unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derailed derailed derailed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davefu113 @derailed