Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API-43688] 526 - Validation for activeDutyEndDate beyond 180 days #20558

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tycol7
Copy link
Contributor

@tycol7 tycol7 commented Jan 31, 2025

Summary

In v1 526, validate that at least one service period activeDutyEndDate is within 180 days from the current date.

Update v1 and v2 docs to include requirement:

Date Completed Active Duty. If in the future, 'separationLocationCode' is required. Cannot be more than 180 days in the future, unless past service is also included.

Related issue(s)

API-43688

Testing done

  • New code is covered by unit tests

Screenshots

v1
v1

v2
v2

What areas of the site does it impact?

526 v1 submission validation. v1 and v2 docs.

Acceptance criteria

  • I added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

N/A

@tycol7 tycol7 marked this pull request as ready for review January 31, 2025 21:42
@tycol7 tycol7 requested a review from a team as a code owner January 31, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
claimsApi modules/claims_api test-passing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants