100496 Throw 500 if any files fail to make it to S3 - IVC CHAMPVA forms

[michaelclement]

Summary

This PR updates the way the IVC CHAMPVA module handles missing uploads when some fail to make it to S3. Previously, the user's submission was allowed to continue if some files failed to make it through. Then steps were taken to manually interpret the submission and determine if enough information made it through.

This created a lot of manual work and room for error. This PR updates the backend so that rather than letting incomplete submissions through, we fail the submission and throw an error that bubbles up to the user. This will prevent users from having a false impression that their submission was acceptable and provides breathing room until the file transmission issue can be worked out.

For more background and context, see this explanation.

Related issue(s)

• Change behavior of uploads controller so if missing file exception occurs, a 500 error is returned/shown to the user va.gov-team#100496

Testing done

• New code is covered by unit tests
• Previously, if some supporting documents didn't make it to S3 a user's submission was allowed to continue
• See this description for steps on testing
• If this work is behind a flipper:
  • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
  • What is the testing plan for rolling out the feature?

Screenshots

NA

What areas of the site does it impact?

IVC CHAMPVA forms

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

Requested Feedback

NA

[cloudmagic80]

LGTM.