Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Metrics/MethodLength disable on Mobile::AppointmentsHelper #20341

Closed
wants to merge 2 commits into from
Closed

Refactor Metrics/MethodLength disable on Mobile::AppointmentsHelper #20341

wants to merge 2 commits into from

Conversation

stevenjcumming
Copy link
Contributor

Summary

  • Refactor create_params to fix Metrics/MethodLength cop

Related issue(s)

  • n/a

Testing done

  • n/a

Acceptance criteria

  • Rubocop disable is removed

@stevenjcumming stevenjcumming self-assigned this Jan 17, 2025
@stevenjcumming stevenjcumming requested a review from a team as a code owner January 17, 2025 00:05
@va-vfs-bot va-vfs-bot temporarily deployed to sjc-mld-appointments-helper/main/main January 17, 2025 00:22 Inactive
@stevenjcumming stevenjcumming marked this pull request as draft January 17, 2025 13:24
@va-vfs-bot va-vfs-bot temporarily deployed to sjc-mld-appointments-helper/main/main January 17, 2025 13:26 Inactive
@stevenjcumming stevenjcumming marked this pull request as ready for review January 17, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aherzberg aherzberg Awaiting requested review from aherzberg aherzberg is a code owner automatically assigned from department-of-veterans-affairs/mobile-api-team

Assignees

@stevenjcumming stevenjcumming

Labels
test-passing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevenjcumming @va-vfs-bot