Fix Rubocop/Style 3

[ryan-mcneil]

Summary

• Fixes the following Rubocop offenses:
  • Style/RedundantConstantBase
    • Remove redundant ::
  • Style/RedundantSelfAssignmentBranch
    • Remove the self-assignment branch
  • Style/RedundantStringEscape
    • Redundant escape of chars inside string literal
  • Style/SelectByRegexp
    • Prefer grep_v to reject/select with a regexp match
  • Style/StringChars
    • Use chars instead of split('')

Related issue(s)

• [VETS-API] Clean up .rubocop_todo.yml va.gov-team#100982

[github-actions]

1 Warning

⚠️

This PR changes 283 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files .rubocop_todo.yml (+0/-63) app/controllers/concerns/accountable.rb (+1/-1) app/controllers/v0/messages_controller.rb (+1/-1) app/controllers/v0/prescriptions_controller.rb (+1/-1) app/models/iam_user.rb (+1/-1) app/models/iam_user_identity.rb (+1/-1) config/environments/production.rb (+1/-1) modules/check_in/spec/services/v2/chip/service_spec.rb (+33/-33) modules/check_in/spec/services/v2/lorota/service_spec.rb (+4/-4) modules/claims_api/app/controllers/claims_api/v2/veterans/claims_controller.rb (+5/-5) modules/claims_api/spec/factories/auto_established_claims.rb (+5/-5) modules/claims_api/spec/factories/power_of_attorney.rb (+2/-2) modules/claims_api/spec/factories/supporting_documents.rb (+1/-1) modules/claims_api/spec/lib/claims_api/homelessness_risk_situation_type_mapper_spec.rb (+2/-2) modules/claims_api/spec/lib/claims_api/homelessness_situation_type_mapper_spec.rb (+2/-2) modules/claims_api/spec/lib/claims_api/special_issue_mappers/bgs_spec.rb (+2/-2) modules/claims_api/spec/lib/claims_api/special_issue_mappers/evss_spec.rb (+2/-2) modules/claims_api/spec/models/power_of_attorney_spec.rb (+1/-1) modules/claims_api/spec/models/supporting_document_spec.rb (+1/-1) modules/claims_api/spec/sidekiq/claim_uploader_spec.rb (+4/-4) modules/claims_api/spec/sidekiq/poa_vbms_sidekiq_spec.rb (+1/-1) modules/meb_api/lib/dgi/status/service.rb (+1/-1) modules/meb_api/spec/dgi/status/service_spec.rb (+1/-1) modules/mobile/app/controllers/mobile/v0/messages_controller.rb (+1/-1) modules/mobile/app/controllers/mobile/v0/prescriptions_controller.rb (+1/-1) modules/my_health/app/controllers/my_health/v1/messages_controller.rb (+1/-1) modules/my_health/app/controllers/my_health/v1/prescriptions_controller.rb (+4/-6) modules/test_user_dashboard/spec/services/create_test_user_account_spec.rb (+2/-2) modules/vba_documents/lib/vba_documents/upload_validator.rb (+1/-1) rakelib/form526.rake (+1/-1) rakelib/test_user_account.rake (+1/-1) spec/factories/evss_claims.rb (+3/-3) spec/factories/form526_submissions.rb (+1/-1) spec/factories/form5655_submission.rb (+3/-3) spec/factories/rubysaml_settings.rb (+2/-2) spec/lib/debt_management_center/sharepoint/request_spec.rb (+1/-1) spec/lib/evss/documents_service_spec.rb (+2/-2) spec/lib/hca/service_spec.rb (+1/-1) spec/lib/search_click_tracking/service_spec.rb (+1/-1) spec/lib/sftp_writer/factory_spec.rb (+1/-1) spec/requests/swagger_spec.rb (+1/-1) spec/serializers/evss_claim_detail_serializer_spec.rb (+1/-1) spec/sidekiq/education_form/create_daily_spool_files_spec.rb (+1/-1) spec/sidekiq/education_form/send_school_certifying_officials_email_spec.rb (+4/-4) spec/sidekiq/evss/document_upload_spec.rb (+1/-1) spec/support/authenticated_session_helper.rb (+1/-1) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger