-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VEBT-1028 - 1995 spool file - modify spool file header benefit type #20329
Open
GcioGregg
wants to merge
3
commits into
master
Choose a base branch
from
vebt-1028-update-spool-file-header
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,7 +7,7 @@ TESTER2 | |
1995R | ||
|
||
|
||
Chapter30 | ||
CH30 | ||
*START* | ||
VA Form 22-1995 | ||
OMB Control #: 2900-0074 | ||
|
39 changes: 39 additions & 0 deletions
39
spec/fixtures/education_benefits_claims/1995/ch1606_baf.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
{ | ||
"veteranFullName": { | ||
"first": "Joe", | ||
"last": "Tester2" | ||
}, | ||
"veteranSocialSecurityNumber": "223334444", | ||
"veteranAddress": { | ||
"city": "Austin", | ||
"country": "USA", | ||
"postalCode": "73301", | ||
"state": "TX", | ||
"street": "1234 Test St" | ||
}, | ||
"sponsorSocialSecurityNumber": "444433322", | ||
"applicantGender": "F", | ||
"dateOfBirth": "1970-01-01", | ||
"email": "[email protected]", | ||
"benefit": "chapter1606", | ||
"benefitUpdate": "chapter1606", | ||
"rudisillReview": "Yes", | ||
"remarks": "remarks", | ||
"programName": "program name", | ||
"privacyAgreementAccepted": true, | ||
"isActiveDuty": true, | ||
"applicantServed": "Yes", | ||
"toursOfDuty": [{ | ||
"dateRange": { | ||
"from": "2010-06-26", | ||
"to": "2011-04-10" | ||
}, | ||
"serviceBranch": "Army Reserve" | ||
}, { | ||
"dateRange": { | ||
"from": "2010-04-22", | ||
"to": "2011-06-14" | ||
}, | ||
"serviceBranch": "navy" | ||
}] | ||
} |
81 changes: 81 additions & 0 deletions
81
spec/fixtures/education_benefits_claims/1995/ch1606_baf.spl
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,81 @@ | ||
*INIT* | ||
JOE | ||
|
||
TESTER2 | ||
223334444 | ||
223334444 | ||
1995R | ||
|
||
|
||
CH1606 | ||
*START* | ||
VA Form 22-1995 | ||
OMB Control #: 2900-0074 | ||
|
||
|
||
REQUEST FOR CHANGE OF BENEFIT, PROGRAM OR PLACE OF TRAINING | ||
FOR VETERANS, SERVICEPERSONS, DEPENDENTS & MEMBERS OF THE SELECTED RESERVE | ||
------------------------------------- | ||
|
||
APPLICANT INFORMATION | ||
--------------------- | ||
|
||
SSN: 223334444 VA File Number: N/A | ||
|
||
Sex: F Date of Birth: 1970-01-01 | ||
|
||
Name: Joe Tester2 | ||
|
||
Address: | ||
1234 TEST ST | ||
AUSTIN, TX, 73301 | ||
USA | ||
|
||
Telephone Numbers: Mobile: | ||
Home: | ||
|
||
Email Address: [email protected] | ||
Preferred Method of Contact: | ||
|
||
Direct Deposit: Type of Account: | ||
Routing/Transit #: Account #: | ||
|
||
TYPE AND PROGRAM OF EDUCATION OR TRAINING | ||
----------------------------------------- | ||
|
||
Benefit Most Recently Received: Chapter1606 | ||
|
||
Do you wish to request a 'Rudisill' review?: Yes | ||
|
||
Select Another Benefit: | ||
|
||
Benefit Being Applied For: | ||
|
||
Type of Education or Training: | ||
Education or Career Goal: | ||
|
||
New School or Training Establishment: | ||
|
||
|
||
APPLICANT ACTIVE DUTY SERVICE INFORMATION | ||
----------------------------------------- | ||
|
||
Served in the armed forces?: Yes | ||
|
||
Are You Now On Active Duty?: YES | ||
|
||
Do you have any new periods of service to record since you last applied for | ||
education benefits? YES | ||
|
||
Date Entered Date Separated Service Component | ||
2010-06-26 2011-04-10 Army Reserve | ||
2010-04-22 2011-06-14 navy | ||
|
||
|
||
As an active-duty service member, you have consulted with an Education Service | ||
Officer (ESO) regarding your education program. | ||
|
||
Electronically Received by VA: 2017-01-17 | ||
Confirmation #: V-EBC-1 | ||
|
||
*END* |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,7 +7,7 @@ TESTER | |
1995R | ||
|
||
|
||
Chapter1606 | ||
CH1606 | ||
*START* | ||
VA Form 22-1995 | ||
OMB Control #: 2900-0074 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,7 +7,7 @@ TESTER | |
1995R | ||
|
||
|
||
Chapter1606 | ||
CH1606 | ||
*START* | ||
VA Form 22-1995 | ||
OMB Control #: 2900-0074 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,7 +7,7 @@ TESTER | |
1995R | ||
|
||
|
||
Chapter35 | ||
CH35 | ||
*START* | ||
VA Form 22-1995 | ||
OMB Control #: 2900-0074 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,7 +7,7 @@ TESTER | |
1995R | ||
|
||
|
||
Chapter30 | ||
CH30 | ||
*START* | ||
VA Form 22-1995 | ||
OMB Control #: 2900-0074 | ||
|
27 changes: 27 additions & 0 deletions
27
spec/fixtures/education_benefits_claims/1995/ch30_mgi_bill.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
{ | ||
"veteranFullName": { | ||
"first": "Joe", | ||
"last": "Tester" | ||
}, | ||
"veteranSocialSecurityNumber": "223334444", | ||
"veteranAddress": { | ||
"city": "Austin", | ||
"country": "USA", | ||
"postalCode": "73301", | ||
"state": "TX", | ||
"street": "123 Test St" | ||
}, | ||
"applicantServed": "No", | ||
"sponsorSocialSecurityNumber": "444433322", | ||
"applicantGender": "F", | ||
"dateOfBirth": "1970-01-01", | ||
"email": "[email protected]", | ||
"benefit": "chapter33Post911", | ||
"benefitUpdate": "chapter33Post911", | ||
"rudisillReview": "Yes", | ||
"changeAnotherBenefit": "Yes", | ||
"benefitAppliedFor": "chapter30", | ||
"remarks": "remarks", | ||
"programName": "program name", | ||
"privacyAgreementAccepted": true | ||
} |
79 changes: 79 additions & 0 deletions
79
spec/fixtures/education_benefits_claims/1995/ch30_mgi_bill.spl
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,79 @@ | ||
*INIT* | ||
JOE | ||
|
||
TESTER | ||
223334444 | ||
223334444 | ||
1995R | ||
|
||
|
||
CH30 | ||
*START* | ||
VA Form 22-1995 | ||
OMB Control #: 2900-0074 | ||
|
||
|
||
REQUEST FOR CHANGE OF BENEFIT, PROGRAM OR PLACE OF TRAINING | ||
FOR VETERANS, SERVICEPERSONS, DEPENDENTS & MEMBERS OF THE SELECTED RESERVE | ||
------------------------------------- | ||
|
||
APPLICANT INFORMATION | ||
--------------------- | ||
|
||
SSN: 223334444 VA File Number: N/A | ||
|
||
Sex: F Date of Birth: 1970-01-01 | ||
|
||
Name: Joe Tester | ||
|
||
Address: | ||
123 TEST ST | ||
AUSTIN, TX, 73301 | ||
USA | ||
|
||
Telephone Numbers: Mobile: | ||
Home: | ||
|
||
Email Address: [email protected] | ||
Preferred Method of Contact: | ||
|
||
Direct Deposit: Type of Account: | ||
Routing/Transit #: Account #: | ||
|
||
TYPE AND PROGRAM OF EDUCATION OR TRAINING | ||
----------------------------------------- | ||
|
||
Benefit Most Recently Received: Chapter33 Post911 | ||
|
||
Do you wish to request a 'Rudisill' review?: Yes | ||
|
||
Select Another Benefit: Yes | ||
|
||
Benefit Being Applied For: Chapter30 | ||
|
||
Type of Education or Training: | ||
Education or Career Goal: | ||
|
||
New School or Training Establishment: | ||
|
||
|
||
APPLICANT ACTIVE DUTY SERVICE INFORMATION | ||
----------------------------------------- | ||
|
||
Served in the armed forces?: No | ||
|
||
Are You Now On Active Duty?: N/A | ||
|
||
Do you have any new periods of service to record since you last applied for | ||
education benefits? NO | ||
|
||
Date Entered Date Separated Service Component | ||
|
||
|
||
Certification and Signature of Applicant | ||
Signature of Applicant Date | ||
|
||
Electronically Received by VA: 2017-01-17 | ||
Confirmation #: V-EBC-1 | ||
|
||
*END* |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,7 +7,7 @@ LAST | |
1995R | ||
|
||
SCHOOL NAME | ||
Chapter1606 | ||
CH1606 | ||
*START* | ||
VA Form 22-1995 | ||
OMB Control #: 2900-0074 | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GcioGregg is there a test that covers this method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stevenjcumming the fixtures that represent the spool file output cover testing that method. There is at least one fixture/spool file (*.spl) for every entry in the hash used by this method. Thanks.