-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Api 43967 fix special issues issue #20324
Open
rockwellwindsor-va
wants to merge
4
commits into
master
Choose a base branch
from
API-43967-fix-special-issues-issue
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adjusts special issue updater code to always be sending an array to avoid code working in one scenario bt not others * Adds test for related method * Adjusts ContentionService definition to avoid wsdl call on every hit to special issues. modified: modules/claims_api/app/clients/claims_api/bgs_client/definitions.rb modified: modules/claims_api/app/sidekiq/claims_api/special_issue_updater.rb modified: modules/claims_api/spec/sidekiq/special_issue_updater_spec.rb
va-vfs-bot
temporarily deployed
to
API-43967-fix-special-issues-issue/main/main
January 16, 2025 18:29
Inactive
tycol7
reviewed
Jan 16, 2025
Comment on lines
153
to
155
# Let's just always know it is an array | ||
contentions = | ||
contention[:special_issues].is_a?(Hash) ? [contention[:special_issues]] : contention[:special_issues] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we just use Array.wrap? No need for a comment.
Suggested change
# Let's just always know it is an array | |
contentions = | |
contention[:special_issues].is_a?(Hash) ? [contention[:special_issues]] : contention[:special_issues] | |
contentions = Array.wrap(contention[:special_issues]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep works perfectly 58de957
tycol7
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
API-43967
Testing done
Screenshots
What areas of the site does it impact?
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?