Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api 43967 fix special issues issue #20324

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rockwellwindsor-va
Copy link
Contributor

@rockwellwindsor-va rockwellwindsor-va commented Jan 16, 2025

Summary

  • Adjusts special issue updater code to always be sending an array to avoid code working in one scenario bt not others
  • Adds test for related method

Related issue(s)

API-43967

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

Screenshots

  • If you run a v1 526 with a special issue you can monitor to make sure the WSDL get call does not occur
Screenshot 2025-01-16 at 11 43 08 AM

What areas of the site does it impact?

modified:   modules/claims_api/app/clients/claims_api/bgs_client/definitions.rb
modified:   modules/claims_api/app/sidekiq/claims_api/special_issue_updater.rb
modified:   modules/claims_api/spec/sidekiq/special_issue_updater_spec.rb

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

* Adjusts special issue updater code to always be sending an array to avoid  code working in one scenario bt not others
* Adds test for related method
* Adjusts ContentionService definition to avoid wsdl call on every hit to special issues.

	modified:   modules/claims_api/app/clients/claims_api/bgs_client/definitions.rb
	modified:   modules/claims_api/app/sidekiq/claims_api/special_issue_updater.rb
	modified:   modules/claims_api/spec/sidekiq/special_issue_updater_spec.rb
@rockwellwindsor-va rockwellwindsor-va added the claimsApi modules/claims_api label Jan 16, 2025
@rockwellwindsor-va rockwellwindsor-va marked this pull request as ready for review January 16, 2025 18:05
@rockwellwindsor-va rockwellwindsor-va requested a review from a team as a code owner January 16, 2025 18:05
@va-vfs-bot va-vfs-bot temporarily deployed to API-43967-fix-special-issues-issue/main/main January 16, 2025 18:29 Inactive
Comment on lines 153 to 155
# Let's just always know it is an array
contentions =
contention[:special_issues].is_a?(Hash) ? [contention[:special_issues]] : contention[:special_issues]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we just use Array.wrap? No need for a comment.

Suggested change
# Let's just always know it is an array
contentions =
contention[:special_issues].is_a?(Hash) ? [contention[:special_issues]] : contention[:special_issues]
contentions = Array.wrap(contention[:special_issues])

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep works perfectly 58de957

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
claimsApi modules/claims_api test-passing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants