Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix org update job #20317

Merged
merged 19 commits into from
Jan 27, 2025
Merged

Fix org update job #20317

merged 19 commits into from
Jan 27, 2025

Conversation

holdenhinkle
Copy link
Contributor

@holdenhinkle holdenhinkle commented Jan 16, 2025

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

  • This work is behind a feature toggle (flipper): YES/NO
  • (Summarize the changes that have been made to the platform)
  • (If bug, how to reproduce)
  • (What is the solution, why is this the solution?)
  • (Which team do you work for, does your team own the maintenance of this component?)
  • (If introducing a flipper, what is the success criteria being targeted?)

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@holdenhinkle holdenhinkle requested review from a team as code owners January 16, 2025 15:44
@holdenhinkle holdenhinkle changed the title Hh fix org update job Fix org update job Jan 16, 2025
@va-vfs-bot va-vfs-bot temporarily deployed to hh-fix-org-update-job/main/main January 16, 2025 16:08 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to hh-fix-org-update-job/main/main January 17, 2025 14:52 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to hh-fix-org-update-job/main/main January 17, 2025 16:46 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to hh-fix-org-update-job/main/main January 17, 2025 19:34 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to hh-fix-org-update-job/main/main January 17, 2025 20:57 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to hh-fix-org-update-job/main/main January 17, 2025 21:51 Inactive
cosu419
cosu419 previously approved these changes Jan 22, 2025
@jvcAdHoc
Copy link
Contributor

This job was a lot of copy and paste from the representative job, do these address validation changes also need to be made there?

@opticbob
Copy link
Contributor

I'll check the rep update job after I finish tracking down all the possible address data object mismatches here.

@opticbob opticbob marked this pull request as draft January 22, 2025 18:27
@opticbob opticbob self-assigned this Jan 27, 2025
@opticbob opticbob merged commit bec9d08 into master Jan 27, 2025
26 checks passed
@opticbob opticbob deleted the hh-fix-org-update-job branch January 27, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants