Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZSF 99536 Migrate BenefitsIntakeStatusJob #20230

Merged
merged 24 commits into from
Jan 28, 2025

Conversation

wayne-weibel
Copy link
Contributor

@wayne-weibel wayne-weibel commented Jan 10, 2025

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

  • This work is behind a feature toggle (flipper): YES
  • activate new submission tracking job with implementation of handlers

Related issue(s)

ZSF | Replace BenefitsIntakeStatusJob with BenefitsIntake::SubmissionStatusJob

Testing done

  • New code is covered by unit tests
  • periodic jobs now tested
  • job ran locally
  • on staging will enable and ensure no error

What areas of the site does it impact?

status checks to lighthouse benefits intake

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)

@wayne-weibel wayne-weibel added burial-benefits Label used for Pull Requests that impact Burial claims (530) pension-benefits Used for PRs that impact Pensions ZSF:Email labels Jan 10, 2025
@va-vfs-bot va-vfs-bot temporarily deployed to zsf-99536-migrate-benefitintake-status-job/main/main January 10, 2025 17:15 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to zsf-99536-migrate-benefitintake-status-job/main/main January 10, 2025 17:42 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to zsf-99536-migrate-benefitintake-status-job/main/main January 10, 2025 21:02 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to zsf-99536-migrate-benefitintake-status-job/main/main January 14, 2025 15:56 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to zsf-99536-migrate-benefitintake-status-job/main/main January 16, 2025 17:57 Inactive
Copy link

github-actions bot commented Jan 17, 2025

1 Warning
⚠️ This PR changes 345 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding
200. Expect some delays getting reviews.

File Summary

Files

  • .github/CODEOWNERS (+2/-1)

  • app/sidekiq/benefits_intake_status_job.rb (+1/-0)

  • config/features.yml (+3/-0)

  • config/initializers/benefits_intake_submission_status_handlers.rb (+12/-0)

  • lib/lighthouse/benefits_intake/sidekiq/submission_status_job.rb (+18/-19)

  • lib/lighthouse/benefits_intake/submission_handler/saved_claim.rb (+10/-17)

  • lib/periodic_jobs.rb (+2/-1)

  • spec/lib/lighthouse/benefits_intake/sidekiq/submission_status_job_spec.rb (+191/-0)

  • spec/lib/lighthouse/benefits_intake/submission_handler/saved_claim_spec.rb (+35/-0)

  • spec/lib/periodic_jobs_spec.rb (+12/-0)

  • spec/sidekiq/benefits_intake_status_job_spec.rb (+15/-0)

  • spec/spec_helper.rb (+6/-0)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf
    

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

@va-vfs-bot va-vfs-bot temporarily deployed to zsf-99536-migrate-benefitintake-status-job/main/main January 17, 2025 22:09 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to zsf-99536-migrate-benefitintake-status-job/main/main January 23, 2025 14:54 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to zsf-99536-migrate-benefitintake-status-job/main/main January 23, 2025 18:38 Inactive
TaiWilkin
TaiWilkin previously approved these changes Jan 23, 2025
Copy link
Contributor

@TaiWilkin TaiWilkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@va-vfs-bot va-vfs-bot temporarily deployed to zsf-99536-migrate-benefitintake-status-job/main/main January 23, 2025 22:04 Inactive
@wayne-weibel wayne-weibel merged commit b02da34 into master Jan 28, 2025
22 of 24 checks passed
@wayne-weibel wayne-weibel deleted the zsf-99536-migrate-benefitintake-status-job branch January 28, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
burial-benefits Label used for Pull Requests that impact Burial claims (530) pension-benefits Used for PRs that impact Pensions require-backend-approval test-passing ZSF:Email
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants