Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-43905-remove-deprecated-models part I #20201

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

stiehlrod
Copy link
Contributor

@stiehlrod stiehlrod commented Jan 9, 2025

Summary

  • Removes decision and find files.
  • Removes load and summary files.

Related issue(s)

What areas of the site does it impact?

deleted:    modules/claims_api/app/models/claims_api/power_of_attorney_request/decision.rb
deleted:    modules/claims_api/app/models/claims_api/power_of_attorney_request/find.rb
deleted:    modules/claims_api/app/models/claims_api/power_of_attorney_request/load.rb
deleted:    modules/claims_api/app/models/claims_api/power_of_attorney_request/summary.rb

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

Please help to make sure that I am not removing anything that we need. TY

@stiehlrod stiehlrod self-assigned this Jan 9, 2025
@stiehlrod stiehlrod changed the title API-43905-remove-deprecated-models API-43905-remove-deprecated-models part I Jan 9, 2025
@stiehlrod stiehlrod marked this pull request as ready for review January 9, 2025 19:37
@stiehlrod stiehlrod requested a review from a team as a code owner January 9, 2025 19:37
@va-vfs-bot va-vfs-bot temporarily deployed to API-43905-remove-deprecated-models/main/main January 9, 2025 20:25 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-43905-remove-deprecated-models/main/main January 10, 2025 15:27 Inactive
tycol7
tycol7 previously approved these changes Jan 10, 2025
@va-vfs-bot va-vfs-bot temporarily deployed to API-43905-remove-deprecated-models/main/main January 10, 2025 21:02 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-43905-remove-deprecated-models/main/main January 13, 2025 21:18 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-43905-remove-deprecated-models/main/main January 14, 2025 20:56 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-43905-remove-deprecated-models/main/main January 15, 2025 14:52 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-43905-remove-deprecated-models/main/main January 16, 2025 16:08 Inactive
tycol7
tycol7 previously approved these changes Jan 16, 2025
Copy link

github-actions bot commented Jan 16, 2025

1 Warning
⚠️ This PR changes 334 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding
200. Expect some delays getting reviews.

File Summary

Files

  • modules/claims_api/app/models/claims_api/power_of_attorney_request/decision.rb (+0/-46)

  • modules/claims_api/app/models/claims_api/power_of_attorney_request/decision/create.rb (+0/-20)

  • modules/claims_api/app/models/claims_api/power_of_attorney_request/find.rb (+0/-33)

  • modules/claims_api/app/models/claims_api/power_of_attorney_request/load.rb (+0/-45)

  • modules/claims_api/app/models/claims_api/power_of_attorney_request/summary.rb (+0/-40)

  • modules/claims_api/app/models/claims_api/power_of_attorney_request/summary/search/query.rb (+0/-89)

  • modules/claims_api/app/services/claims_api/power_of_attorney_request_service/search/query.rb (+0/-61)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf
    

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

@va-vfs-bot va-vfs-bot temporarily deployed to API-43905-remove-deprecated-models/main/main January 16, 2025 18:29 Inactive
tycol7
tycol7 previously approved these changes Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants