VEBT-1028 - 1995 spool file - modify spool file header benefit type (#…

…20329)

* modify spool file header for 1995

* fix broken rspec

---------

Co-authored-by: nfstern02 <[email protected]>

app/sidekiq/education_form/forms/va_1995.rb

@@ -8,6 +8,7 @@ class VA1995 < Base
       chapter33: 'CH33',
       chapter33Post911: 'CH33',
       chapter33FryScholarship: 'CH33',
+      chapter35: 'CH35',
       chapter1606: 'CH1606',
       chapter1607: 'CH1607',
       transferOfEntitlement: 'TransferOfEntitlement'
@@ -17,6 +18,12 @@ def school
       @applicant.newSchool
     end
 
+    def header_abbreviated_form_type(header_form_type)
+      return 'CH33' if header_form_type.eql?('transferOfEntitlement')
+
+      FORM_TYPES[header_form_type&.to_sym]
+    end
+
     def form_type
       FORM_TYPES[@applicant.benefit&.to_sym]
     end

app/sidekiq/education_form/templates/1995.erb

@@ -1,8 +1,8 @@
 <%= parse_with_template_path('header_1995') %>
 <% if @applicant.benefitAppliedFor -%>
-<%= @applicant.benefitAppliedFor&.titleize %>
+<%= header_abbreviated_form_type(@applicant.benefitAppliedFor)%>
 <% else -%>
-<%= form_benefit %>
+<%= header_abbreviated_form_type(@applicant.benefitUpdate)%>
 <% end -%>
 *START*
 VA Form 22-1995

spec/fixtures/education_benefits_claims/1995/ch1606.spl

@@ -7,7 +7,7 @@ TESTER2
 1995R
 
 
-Chapter30
+CH30
 *START*
 VA Form 22-1995
 OMB Control #: 2900-0074

spec/fixtures/education_benefits_claims/1995/ch1606_baf.json

@@ -0,0 +1,39 @@
+{
+  "veteranFullName": {
+    "first": "Joe",
+    "last": "Tester2"
+  },
+  "veteranSocialSecurityNumber": "223334444",
+  "veteranAddress": {
+    "city": "Austin",
+    "country": "USA",
+    "postalCode": "73301",
+    "state": "TX",
+    "street": "1234 Test St"
+  },
+  "sponsorSocialSecurityNumber": "444433322",
+  "applicantGender": "F",
+  "dateOfBirth": "1970-01-01",
+  "email": "[email protected]",
+  "benefit": "chapter1606",
+  "benefitUpdate": "chapter1606",
+  "rudisillReview": "Yes",
+  "remarks": "remarks",
+  "programName": "program name",
+  "privacyAgreementAccepted": true,
+  "isActiveDuty": true,
+  "applicantServed": "Yes",
+  "toursOfDuty": [{
+    "dateRange": {
+      "from": "2010-06-26",
+      "to": "2011-04-10"
+    },
+    "serviceBranch": "Army Reserve"
+  }, {
+    "dateRange": {
+      "from": "2010-04-22",
+      "to": "2011-06-14"
+    },
+    "serviceBranch": "navy"
+  }]
+}

spec/fixtures/education_benefits_claims/1995/ch1606_baf.spl

@@ -0,0 +1,81 @@
+*INIT*
+JOE
+
+TESTER2
+223334444
+223334444
+1995R
+
+
+CH1606
+*START*
+VA Form 22-1995
+OMB Control #: 2900-0074
+
+
+        REQUEST FOR CHANGE OF BENEFIT, PROGRAM OR PLACE OF TRAINING
+FOR VETERANS, SERVICEPERSONS, DEPENDENTS & MEMBERS OF THE SELECTED RESERVE
+                    -------------------------------------
+
+                            APPLICANT INFORMATION
+                            ---------------------
+
+SSN: 223334444    VA File Number: N/A
+
+Sex: F  Date of Birth: 1970-01-01
+
+Name:   Joe Tester2
+
+Address:
+1234 TEST ST
+AUSTIN, TX, 73301
+USA
+
+Telephone Numbers:     Mobile:
+                       Home:
+
+Email Address:  [email protected]
+Preferred Method of Contact:
+
+Direct Deposit:     Type of Account:
+Routing/Transit #:    Account #:
+
+                  TYPE AND PROGRAM OF EDUCATION OR TRAINING
+                  -----------------------------------------
+
+Benefit Most Recently Received: Chapter1606
+
+Do you wish to request a 'Rudisill' review?: Yes
+
+Select Another Benefit:
+
+Benefit Being Applied For:
+
+Type of Education or Training:
+Education or Career Goal:
+
+New School or Training Establishment:
+
+
+                  APPLICANT ACTIVE DUTY SERVICE INFORMATION
+                  -----------------------------------------
+
+Served in the armed forces?: Yes
+
+Are You Now On Active Duty?: YES
+
+Do you have any new periods of service to record since you last applied for
+education benefits? YES
+
+Date Entered   Date Separated     Service Component
+2010-06-26     2011-04-10         Army Reserve
+2010-04-22     2011-06-14         navy
+
+
+As an active-duty service member, you have consulted with an Education Service
+Officer (ESO) regarding your education program.
+
+Electronically Received by VA:  2017-01-17
+Confirmation #:  V-EBC-1
+
+*END*

spec/fixtures/education_benefits_claims/1995/ch30.spl

@@ -7,7 +7,7 @@ TESTER
 1995R
 
 
-Chapter1606
+CH1606
 *START*
 VA Form 22-1995
 OMB Control #: 2900-0074

spec/fixtures/education_benefits_claims/1995/ch30_guardian_graduated.spl

@@ -7,7 +7,7 @@ TESTER
 1995R
 
 
-Chapter1606
+CH1606
 *START*
 VA Form 22-1995
 OMB Control #: 2900-0074

spec/fixtures/education_benefits_claims/1995/ch30_guardian_graduated_sponsor.spl

@@ -7,7 +7,7 @@ TESTER
 1995R
 
 
-Chapter35
+CH35
 *START*
 VA Form 22-1995
 OMB Control #: 2900-0074

spec/fixtures/education_benefits_claims/1995/ch30_guardian_not_graduated.spl

@@ -7,7 +7,7 @@ TESTER
 1995R
 
 
-Chapter30
+CH30
 *START*
 VA Form 22-1995
 OMB Control #: 2900-0074

spec/fixtures/education_benefits_claims/1995/ch30_mgi_bill.json

@@ -0,0 +1,27 @@
+{
+  "veteranFullName": {
+    "first": "Joe",
+    "last": "Tester"
+  },
+  "veteranSocialSecurityNumber": "223334444",
+  "veteranAddress": {
+    "city": "Austin",
+    "country": "USA",
+    "postalCode": "73301",
+    "state": "TX",
+    "street": "123 Test St"
+  },
+  "applicantServed": "No",
+  "sponsorSocialSecurityNumber": "444433322",
+  "applicantGender": "F",
+  "dateOfBirth": "1970-01-01",
+  "email": "[email protected]",
+  "benefit": "chapter33Post911",
+  "benefitUpdate": "chapter33Post911",
+  "rudisillReview": "Yes",
+  "changeAnotherBenefit": "Yes",
+  "benefitAppliedFor": "chapter30",
+  "remarks": "remarks",
+  "programName": "program name",
+  "privacyAgreementAccepted": true
+}

spec/fixtures/education_benefits_claims/1995/ch30_mgi_bill.spl

@@ -0,0 +1,79 @@
+*INIT*
+JOE
+
+TESTER
+223334444
+223334444
+1995R
+
+
+CH30
+*START*
+VA Form 22-1995
+OMB Control #: 2900-0074
+
+
+        REQUEST FOR CHANGE OF BENEFIT, PROGRAM OR PLACE OF TRAINING
+FOR VETERANS, SERVICEPERSONS, DEPENDENTS & MEMBERS OF THE SELECTED RESERVE
+                    -------------------------------------
+
+                            APPLICANT INFORMATION
+                            ---------------------
+
+SSN: 223334444    VA File Number: N/A
+
+Sex: F  Date of Birth: 1970-01-01
+
+Name:   Joe Tester
+
+Address:
+123 TEST ST
+AUSTIN, TX, 73301
+USA
+
+Telephone Numbers:     Mobile:
+                       Home:
+
+Email Address:  [email protected]
+Preferred Method of Contact:
+
+Direct Deposit:     Type of Account:
+Routing/Transit #:    Account #:
+
+                  TYPE AND PROGRAM OF EDUCATION OR TRAINING
+                  -----------------------------------------
+
+Benefit Most Recently Received: Chapter33 Post911
+
+Do you wish to request a 'Rudisill' review?: Yes
+
+Select Another Benefit: Yes
+
+Benefit Being Applied For: Chapter30
+
+Type of Education or Training:
+Education or Career Goal:
+
+New School or Training Establishment:
+
+
+                  APPLICANT ACTIVE DUTY SERVICE INFORMATION
+                  -----------------------------------------
+
+Served in the armed forces?: No
+
+Are You Now On Active Duty?: N/A
+
+Do you have any new periods of service to record since you last applied for
+education benefits? NO
+
+Date Entered   Date Separated     Service Component
+
+
+      Certification and Signature of Applicant
+Signature of Applicant                                               Date
+
+Electronically Received by VA:  2017-01-17
+Confirmation #:  V-EBC-1
+
+*END*

spec/fixtures/education_benefits_claims/1995/ch33_fry.spl

@@ -7,7 +7,7 @@ LAST
 1995R
 
 SCHOOL NAME
-Chapter1606
+CH1606
 *START*
 VA Form 22-1995
 OMB Control #: 2900-0074