Merge branch 'master' into API-43905-remove-deprecated-models

.github/CODEOWNERS

@@ -158,7 +158,6 @@ app/controllers/v0/virtual_agent/virtual_agent_appeal_controller.rb @department-
 app/controllers/v0/virtual_agent/virtual_agent_claim_status_controller.rb @department-of-veterans-affairs/vfs-virtual-agent-chatbot @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 app/controllers/v0/veteran_onboardings_controller.rb @department-of-veterans-affairs/backend-review-group @department-of-veterans-affairs/va-iir
 app/controllers/v1/gids @department-of-veterans-affairs/govcio-vfep-codereviewers @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
-app/controllers/v1/higher_level_reviews_controller.rb @department-of-veterans-affairs/benefits-decision-reviews-be @department-of-veterans-affairs/backend-review-group
 app/controllers/v1/higher_level_reviews @department-of-veterans-affairs/benefits-decision-reviews-be @department-of-veterans-affairs/backend-review-group
 app/controllers/v1/notice_of_disagreements @department-of-veterans-affairs/benefits-decision-reviews-be @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 app/controllers/v1/post911_gi_bill_statuses_controller.rb @department-of-veterans-affairs/govcio-vfep-codereviewers @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
@@ -1352,6 +1351,7 @@ spec/sidekiq/central_mail/submit_central_form686c_job_spec.rb @department-of-vet
 spec/sidekiq/copay_notifications @department-of-veterans-affairs/vsa-debt-resolution @department-of-veterans-affairs/backend-review-group
 spec/sidekiq/cypress_viewport_updater/cypress_config_js_file_spec.rb @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/sidekiq/cypress_viewport_updater/github_service_spec.rb @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
+spec/sidekiq/cypress_viewport_updater/update_cypress_viewports_job_spec.rb @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/sidekiq/cypress_viewport_updater/viewport_preset_js_file_spec.rb @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/sidekiq/decision_review @department-of-veterans-affairs/benefits-decision-reviews-be @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/sidekiq/education_form @department-of-veterans-affairs/my-education-benefits @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
@@ -1397,6 +1397,7 @@ spec/sidekiq/mhv @department-of-veterans-affairs/vfs-mhv-medical-records @depart
 spec/sidekiq/mhv/account_creator_job_spec.rb @department-of-veterans-affairs/octo-identity
 spec/sidekiq/pager_duty @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/sidekiq/preneeds @department-of-veterans-affairs/mbs-core-team @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
+spec/sidekiq/process_file_job_spec.rb @department-of-veterans-affairs/backend-review-group
 spec/sidekiq/schema_contract @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/sidekiq/sign_in @department-of-veterans-affairs/octo-identity
 spec/sidekiq/sign_in/delete_expired_sessions_job_spec.rb @department-of-veterans-affairs/octo-identity
@@ -1428,8 +1429,13 @@ spec/lib/common/client/concerns/mhv_fhir_session_client_spec.rb @department-of-v
 spec/lib/common/client/concerns/mhv_jwt_session_client_spec.rb @department-of-veterans-affairs/vfs-mhv-medical-records @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/lib/common/client/concerns/mhv_locked_session_client_spec.rb @department-of-veterans-affairs/vfs-mhv-medical-records @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/lib/common/client/middleware @department-of-veterans-affairs/backend-review-group
+spec/lib/common/client/session_spec.rb @department-of-veterans-affairs/backend-review-group
 spec/lib/common/convert_to_pdf_spec.rb @department-of-veterans-affairs/backend-review-group
+spec/lib/common/exceptions/detailed_schema_errors_spec.rb @department-of-veterans-affairs/backend-review-group
+spec/lib/common/models/base_spec.rb @department-of-veterans-affairs/backend-review-group
+spec/lib/common/models/collection_spec.rb @department-of-veterans-affairs/backend-review-group
 spec/lib/common/models/concerns/cache_aside_spec.rb @department-of-veterans-affairs/backend-review-group
+spec/lib/common/models/redis_store_spec.rb @department-of-veterans-affairs/backend-review-group
 spec/lib/common/pdf_helpers_spec.rb @department-of-veterans-affairs/benefits-decision-reviews-be @department-of-veterans-affairs/backend-review-group
 spec/lib/debt_management_center @department-of-veterans-affairs/vsa-debt-resolution @department-of-veterans-affairs/backend-review-group
 spec/lib/decision_review @department-of-veterans-affairs/benefits-decision-reviews-be @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
@@ -1753,7 +1759,6 @@ spec/requests/v1/higher_level_reviews @department-of-veterans-affairs/benefits-d
 spec/requests/v1/notice_of_disagreements @department-of-veterans-affairs/benefits-decision-reviews-be @department-of-veterans-affairs/backend-review-group
 spec/requests/v1/supplemental_claims @department-of-veterans-affairs/benefits-decision-reviews-be @department-of-veterans-affairs/backend-review-group
 spec/requests/v1/apidoc @department-of-veterans-affairs/backend-review-group
-spec/requests/v1/higher_level_reviews_spec.rb  @department-of-veterans-affairs/benefits-decision-reviews-be @department-of-veterans-affairs/backend-review-group
 spec/requests/v1/notice_of_disagreements_spec.rb  @department-of-veterans-affairs/backend-review-group @department-of-veterans-affairs/benefits-decision-reviews-be
 spec/requests/v1/post911_gi_bill_status_spec.rb @department-of-veterans-affairs/govcio-vfep-codereviewers @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/requests/v1/supplemental_claims_spec.rb  @department-of-veterans-affairs/backend-review-group @department-of-veterans-affairs/benefits-decision-reviews-be
@@ -1837,6 +1842,7 @@ spec/services/evss_claim_service_async_spec.rb @department-of-veterans-affairs/b
 spec/services/evss_claim_service_spec.rb @department-of-veterans-affairs/benefits-management-tools-be @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/services/form1010cg @department-of-veterans-affairs/vfs-10-10 @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/services/form1010_ezr_attachments/file_type_validator_spec.rb @department-of-veterans-affairs/vfs-10-10 @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
+spec/services/form_durations/worker_spec.rb @department-of-veterans-affairs/backend-review-group
 spec/services/hca/overrides_parser_spec.rb @department-of-veterans-affairs/vfs-10-10 @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/services/identity @department-of-veterans-affairs/octo-identity
 spec/services/login @department-of-veterans-affairs/octo-identity

.rubocop_todo.yml

@@ -148,63 +148,6 @@ Lint/MissingSuper:
     - 'modules/veteran/app/models/veteran/user.rb'
     - 'lib/vye/dgib/service.rb'
 
-# Offense count: 5
-Lint/NoReturnInBeginEndBlocks:
-  Exclude:
-    - 'lib/saml/user_attributes/ssoe.rb'
-    - 'modules/check_in/app/services/travel_claim/service.rb'
-    - 'modules/check_in/app/services/v2/chip/service.rb'
-    - 'modules/mobile/app/models/mobile/v0/adapters/vaos_v2_appointment.rb'
-
-# Offense count: 18
-# This cop supports unsafe autocorrection (--autocorrect-all).
-Lint/NonAtomicFileOperation:
-  Exclude:
-    - 'config/initializers/integration_recorder.rb'
-    - 'lib/common/file_helpers.rb'
-    - 'lib/generators/module/module_generator.rb'
-    - 'modules/appeals_api/app/sidekiq/appeals_api/pdf_submit_job.rb'
-    - 'modules/appeals_api/spec/services/appeals_api/pdf_construction/generator_spec.rb'
-    - 'modules/mobile/app/services/mobile/v0/claims/proxy.rb'
-    - 'spec/controllers/v0/caregivers_assistance_claims_controller_spec.rb'
-    - 'spec/models/form1010cg/attachment_spec.rb'
-    - 'spec/rswag_override.rb'
-
-# Offense count: 4
-# This cop supports unsafe autocorrection (--autocorrect-all).
-Lint/OrAssignmentToConstant:
-  Exclude:
-    - 'modules/appeals_api/app/controllers/concerns/appeals_api/header_modification.rb'
-    - 'modules/claims_api/app/controllers/concerns/claims_api/endpoint_deprecation.rb'
-
-# Offense count: 16
-# This cop supports safe autocorrection (--autocorrect).
-Lint/RedundantCopDisableDirective:
-  Exclude:
-    - 'modules/mobile/lib/scripts/appointments_list_validation.rb'
-    - 'rakelib/form526.rake'
-    - 'rakelib/mvi.rake'
-    - 'rakelib/vet360.rake'
-
-# Offense count: 2
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: AllowedMethods.
-# AllowedMethods: instance_of?, kind_of?, is_a?, eql?, respond_to?, equal?, presence, present?
-Lint/RedundantSafeNavigation:
-  Exclude:
-    - 'app/sidekiq/education_form/process10203_submissions.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-Lint/RedundantStringCoercion:
-  Exclude:
-    - 'rakelib/form526.rake'
-
-# Offense count: 1
-Lint/RequireRangeParentheses:
-  Exclude:
-    - 'rakelib/form526.rake'
-
 # Offense count: 976
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
@@ -252,12 +195,6 @@ Lint/SymbolConversion:
     - 'spec/lib/github_authentication/coverband_reporters_web_spec.rb'
     - 'spec/lib/lighthouse/veterans_health/client_spec.rb'
 
-# Offense count: 3
-Lint/UselessRescue:
-  Exclude:
-    - 'app/controllers/v0/contact_us/inquiries_controller.rb'
-    - 'lib/lgy/service.rb'
-
 # Offense count: 1074
 # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
 Metrics/AbcSize:
@@ -366,79 +303,6 @@ Naming/VariableNumber:
     - 'spec/sidekiq/facilities/state_cemetery_reload_job_spec.rb'
     - 'spec/sidekiq/form1010cg/delete_old_uploads_job_spec.rb'
 
-# Offense count: 1075
-# This cop supports unsafe autocorrection (--autocorrect-all).
-RSpec/BeEq:
-  Enabled: false
-
-# Offense count: 45
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: be, be_nil
-RSpec/BeNil:
-  Exclude:
-    - 'modules/appeals_api/spec/models/higher_level_review/phone_spec.rb'
-    - 'modules/claims_api/spec/models/auto_establish_claim_spec.rb'
-    - 'modules/va_notify/spec/models/confirmation_email_spec.rb'
-    - 'modules/vba_documents/spec/models/upload_submission_spec.rb'
-    - 'modules/vba_documents/spec/sidekiq/upload_processor_spec.rb'
-    - 'spec/controllers/v0/users_controller_spec.rb'
-    - 'spec/lib/common/models/concerns/cache_aside_spec.rb'
-    - 'spec/lib/evss/auth_headers_spec.rb'
-    - 'spec/lib/evss/pciu/request_body_spec.rb'
-    - 'spec/lib/facilities/drivetime_bands/response_spec.rb'
-    - 'spec/lib/formatters/date_formatter_spec.rb'
-    - 'spec/lib/identity/parsers/gc_ids_helper_spec.rb'
-    - 'spec/lib/mpi/responses/parser_base_spec.rb'
-    - 'spec/lib/pdf_fill/forms/form_helper_spec.rb'
-    - 'spec/lib/sentry/scrubbers/filter_request_body_spec.rb'
-    - 'spec/lib/sidekiq/form526_backup_submission_process/submit_spec.rb'
-    - 'spec/models/education_benefits_claim_spec.rb'
-    - 'spec/models/form526_submission_spec.rb'
-    - 'spec/models/mpi_data_spec.rb'
-    - 'spec/models/user_spec.rb'
-    - 'spec/services/bgs/people/request_spec.rb'
-    - 'spec/services/identity/account_creator_spec.rb'
-    - 'spec/services/sign_in/attribute_validator_spec.rb'
-    - 'spec/sidekiq/webhooks/callback_url_job_spec.rb'
-
-# Offense count: 11
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: NegatedMatcher.
-RSpec/ChangeByZero:
-  Exclude:
-    - 'spec/lib/flipper/instrumentation/event_subscriber_spec.rb'
-    - 'spec/lib/sidekiq/form526_backup_submission_process/submit_spec.rb'
-    - 'spec/models/form526_submission_spec.rb'
-    - 'spec/models/saved_claim/education_benefits/va10203_spec.rb'
-    - 'spec/sidekiq/in_progress_form_cleaner_spec.rb'
-
-# Offense count: 25
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: be_a, be_kind_of
-RSpec/ClassCheck:
-  Exclude:
-    - 'spec/controllers/v0/virtual_agent/virtual_agent_appeal_spec.rb'
-    - 'spec/controllers/v0/virtual_agent/virtual_agent_claim_spec.rb'
-    - 'spec/lib/common/models/redis_store_spec.rb'
-    - 'spec/lib/iam_ssoe_oauth/session_manager_spec.rb'
-
-# Offense count: 17
-# This cop supports safe autocorrection (--autocorrect).
-RSpec/ExcessiveDocstringSpacing:
-  Exclude:
-    - 'modules/check_in/spec/services/v2/lorota/service_spec.rb'
-    - 'modules/claims_api/spec/models/auto_establish_claim_spec.rb'
-    - 'modules/dhp_connected_devices/spec/services/dhp_connected_devices/token_storage_service_spec.rb'
-    - 'modules/va_forms/spec/lib/regex_helper_spec.rb'
-    - 'spec/controllers/v0/virtual_agent/virtual_agent_appeal_spec.rb'
-    - 'spec/lib/evss/disability_compensation_form/data_translation_all_claim_spec.rb'
-    - 'spec/lib/generators/module/module_generator_spec.rb'
-    - 'spec/mailers/veteran_readiness_employment_mailer_spec.rb'
-    - 'spec/models/facilities_query_spec.rb'
-    - 'spec/sidekiq/vre/create_ch31_submissions_report_job_spec.rb'
-
 # Offense count: 57
 # Configuration parameters: AllowedPatterns.
 # AllowedPatterns: ^expect_, ^assert_
@@ -491,20 +355,6 @@ RSpec/PendingWithoutReason:
     - 'spec/requests/breakers_integration_spec.rb'
     - 'spec/sidekiq/facilities/mental_health_reload_job_spec.rb'
 
-# Offense count: 10
-# This cop supports safe autocorrection (--autocorrect).
-RSpec/SortMetadata:
-  Exclude:
-    - 'spec/lib/sftp_writer/factory_spec.rb'
-    - 'spec/requests/authentication/standard_authentication_spec.rb'
-    - 'spec/requests/swagger_spec.rb'
-    - 'spec/sidekiq/education_form/create10203_applicant_decision_letters_spec.rb'
-    - 'spec/sidekiq/education_form/create_daily_spool_files_spec.rb'
-    - 'spec/sidekiq/education_form/forms/base_spec.rb'
-    - 'spec/sidekiq/education_form/forms/va1990_spec.rb'
-    - 'spec/sidekiq/education_form/process10203_submissions_spec.rb'
-    - 'spec/sidekiq/education_form/send_school_certifying_officials_email_spec.rb'
-
 # Offense count: 715
 RSpec/StubbedMock:
   Enabled: false
@@ -529,65 +379,6 @@ RSpec/SubjectDeclaration:
     - 'spec/sidekiq/pager_duty/cache_global_downtime_spec.rb'
     - 'spec/uploaders/form1010cg/poa_uploader_spec.rb'
 
-# Offense count: 91
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: constant, string
-RSpec/VerifiedDoubleReference:
-  Exclude:
-    - 'modules/appeals_api/spec/lib/health_checker_spec.rb'
-    - 'modules/appeals_api/spec/services/appeals_api/central_mail_updater_spec.rb'
-    - 'modules/appeals_api/spec/sidekiq/appeals_api/daily_error_report_spec.rb'
-    - 'modules/appeals_api/spec/sidekiq/appeals_api/monthly_stats_report_spec.rb'
-    - 'modules/appeals_api/spec/sidekiq/concerns/appeals_api/report_recipients_reader_spec.rb'
-    - 'modules/appeals_api/spec/sidekiq/decision_review_report_daily_spec.rb'
-    - 'modules/appeals_api/spec/sidekiq/decision_review_report_weekly_spec.rb'
-    - 'modules/appeals_api/spec/sidekiq/higher_level_review_upload_status_batch_spec.rb'
-    - 'modules/appeals_api/spec/sidekiq/higher_level_review_upload_status_updater_spec.rb'
-    - 'modules/appeals_api/spec/sidekiq/notice_of_disagreement_upload_status_batch_spec.rb'
-    - 'modules/appeals_api/spec/sidekiq/notice_of_disagreement_upload_status_updater_spec.rb'
-    - 'modules/appeals_api/spec/sidekiq/pdf_submit_job_spec.rb'
-    - 'modules/appeals_api/spec/sidekiq/supplemental_claim_upload_status_batch_spec.rb'
-    - 'modules/appeals_api/spec/sidekiq/supplemental_claim_upload_status_updater_spec.rb'
-    - 'modules/appeals_api/spec/support/shared_examples_for_monitored_worker.rb'
-    - 'modules/claims_api/spec/sidekiq/claim_establisher_spec.rb'
-    - 'modules/claims_api/spec/sidekiq/claim_uploader_spec.rb'
-    - 'modules/claims_api/spec/sidekiq/poa_vbms_updater_spec.rb'
-    - 'modules/vba_documents/spec/models/upload_submission_spec.rb'
-    - 'modules/vba_documents/spec/sidekiq/upload_processor_spec.rb'
-    - 'modules/vba_documents/spec/sidekiq/upload_status_batch_spec.rb'
-    - 'modules/vba_documents/spec/sidekiq/upload_status_updater_spec.rb'
-    - 'spec/controllers/v1/sessions_controller_spec.rb'
-    - 'spec/lib/common/client/middleware/request/soap_headers_spec.rb'
-    - 'spec/lib/evss/intent_to_file/response_strategy_spec.rb'
-    - 'spec/lib/evss/pciu_address/response_strategy_spec.rb'
-    - 'spec/lib/iam_ssoe_oauth/configuration_spec.rb'
-    - 'spec/lib/iam_ssoe_oauth/service_spec.rb'
-    - 'spec/lib/iam_ssoe_oauth/session_manager_spec.rb'
-    - 'spec/lib/mpi/configuration_spec.rb'
-    - 'spec/lib/mpi/responses/add_parser_spec.rb'
-    - 'spec/lib/mpi/responses/profile_parser_spec.rb'
-    - 'spec/lib/shrine/plugins/validate_unlocked_pdf_spec.rb'
-    - 'spec/lib/shrine/plugins/validate_virus_free_spec.rb'
-    - 'spec/models/facilities/vha_facility_spec.rb'
-    - 'spec/requests/swagger_spec.rb'
-    - 'spec/services/evss_claim_service_spec.rb'
-    - 'spec/services/mhv_account_type_service_spec.rb'
-    - 'spec/sidekiq/cypress_viewport_updater/update_cypress_viewports_job_spec.rb'
-    - 'spec/sidekiq/education_form/create_daily_spool_files_spec.rb'
-    - 'spec/sidekiq/evss/document_upload_spec.rb'
-    - 'spec/sidekiq/evss/request_decision_spec.rb'
-    - 'spec/sidekiq/evss/retrieve_claims_from_remote_job_spec.rb'
-    - 'spec/sidekiq/evss/update_claim_from_remote_job_spec.rb'
-    - 'spec/sidekiq/facilities/access_data_download_spec.rb'
-    - 'spec/sidekiq/facilities/facility_location_download_job_spec.rb'
-    - 'spec/sidekiq/facilities/pssg_download_spec.rb'
-    - 'spec/sidekiq/form526_confirmation_email_job_spec.rb'
-    - 'spec/sidekiq/pager_duty/cache_global_downtime_spec.rb'
-    - 'spec/sidekiq/pager_duty/poll_maintenance_windows_spec.rb'
-    - 'spec/sidekiq/webhooks/callback_url_job_spec.rb'
-    - 'spec/support/poa_stub.rb'
-
 # Offense count: 87
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: ResponseMethods.