Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: reduce generated error handling code in ops #1033

Merged
merged 8 commits into from
Jan 7, 2025
Merged

perf: reduce generated error handling code in ops #1033

merged 8 commits into from
Jan 7, 2025
+177 −888

Conversation

ry
Copy link
Member

@ry ry commented Jan 6, 2025 •
edited
Loading

deno release build is about 700kb smaller with this patch

110239496 this patch
110942920 main

@ry ry marked this pull request as draft January 6, 2025 21:04
littledivy
littledivy approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you update the tests output with UPDATE_EXPECTED=1 CI=1 cargo test?

@ry ry marked this pull request as ready for review January 7, 2025 21:17
@ry ry changed the title perf: reduce generated op code by moving error handling perf: reduce generated error handling code in ops Jan 7, 2025
@ry ry enabled auto-merge (squash) January 7, 2025 21:22
@ry ry merged commit abe12fd into main Jan 7, 2025
18 checks passed
@ry ry deleted the throw_error branch January 7, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littledivy littledivy littledivy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ry @littledivy