Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add return types to call() methods. #32

Merged
merged 6 commits into from
Nov 17, 2023
Merged

Conversation

sentilesdal
Copy link
Contributor

  • update snapshots to include call fns
  • add return types to call() methods

@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (4789f4f) 68.44% compared to head (3aedd2b) 67.52%.

Files Patch % Lines
pypechain/utilities/types.py 54.54% 10 Missing ⚠️
pypechain/render/contract.py 33.33% 4 Missing ⚠️
pypechain/utilities/format.py 0.00% 3 Missing ⚠️
pypechain/utilities/abi.py 96.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
- Coverage   68.44%   67.52%   -0.92%     
==========================================
  Files          17       17              
  Lines         507      545      +38     
==========================================
+ Hits          347      368      +21     
- Misses        160      177      +17     
Flag Coverage Δ
unittests 67.52% <68.96%> (-0.92%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pypechain/utilities/abi.py Outdated Show resolved Hide resolved
@sentilesdal sentilesdal marked this pull request as ready for review November 17, 2023 16:22
@sentilesdal sentilesdal merged commit 9aeb77a into main Nov 17, 2023
3 checks passed
@sentilesdal sentilesdal deleted the matt-add-return-types branch November 17, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants