fix: Update group name on self-additions and missing messages (#6412) #6414
+30
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating the group name on self-additions and missing messages was forgotten. The only thing is that we don't add a system message (`MsgGrpNameChangedBy`) in these cases because we don't want to blame anyone.
|
This definitely needs a rebase now. Or rather a rewrite, seems all the actual logic has been changed. And as mentioned in #6401 (comment) maybe introduce a new header for the change timestamp, then apply last-write-wins logic to the group name. For compatibility with older Delta Chat explict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6412
If this conflicts with #6404, this may be merged later, the bug isn't good, but it exists for years it seems and nobody complained before. Btw, maybe we want to apply the same consistency algorithm to the group name.