pass account ID in chat shortcuts and properly switch to account #3558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To test the changes in this pull request, install this apk: |
r10s
approved these changes
Jan 23, 2025
Comment on lines
-211
to
-215
| String shortcutId = intent.getStringExtra(ShortcutManagerCompat.EXTRA_SHORTCUT_ID); | ||
| if (chatId == -1 && shortcutId != null) { | ||
| chatId = Integer.parseInt(shortcutId); | ||
| } | ||
|
|
There was a problem hiding this comment.
wondering where this came from. indeed, looks useless :)
There was a problem hiding this comment.
Yes, couldn't find any similar usage in the Internet, maybe we were using the intent ID to pass the chat id at the beginning so this was kept as a migration step or it was from android <=4 times
There was a problem hiding this comment.
And we don't even do it for other shortcuts we create
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3557