Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set correct mime type for .wasm files #2636

Merged
merged 1 commit into from
Aug 12, 2023
Merged

Conversation

r10s
Copy link
Member

@r10s r10s commented Aug 12, 2023

in case, getMimeTypeFromExtension()
fails to figure out the mime type for .wasm files, we set application/wasm manually afterwards

closes #2635

in case, getMimeTypeFromExtension()
fails to figure out the mime type for .wasm files,
we set application/wasm manually afterwards
@github-actions
Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

@r10s r10s requested review from WofWca and ralphtheninja August 12, 2023 14:16
Copy link
Collaborator

@WofWca WofWca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk, the preview .apk just closes immediately for me. But I think this will fix the issue (at least my specific one).

@r10s
Copy link
Member Author

r10s commented Aug 12, 2023

Idk, the preview .apk just closes immediately for me. But I think this will fix the issue (at least my specific one).

that's maybe because of some wrong core-submodule, locally it builds+runs for me

@r10s r10s merged commit 5c51339 into stable Aug 12, 2023
@r10s r10s deleted the correct-mime-type-for-wasm branch August 12, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants