Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update to DataFusion 45.0.0 / arrow/parquet 54.0.0 #3175

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Feb 1, 2025

Description

Upgrade to DataFusion 45

WIP / Testing PR

Related Issue(s)

Documentation

Copy link

github-actions bot commented Feb 1, 2025

ACTION NEEDED

delta-rs follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

@github-actions github-actions bot added the binding/python Issues for the Python package label Feb 1, 2025
@alamb
Copy link
Contributor Author

alamb commented Feb 1, 2025

It appears we will also have to update delta kernel with the new arrow first:
#delta_kernel = { version = "=0.6.0", features = ["default-engine"] }

@rtyler
Copy link
Member

rtyler commented Feb 1, 2025

Yeah, I have this change which I would like to land to also make this easier

@alamb alamb requested review from rtyler and hntd187 as code owners February 1, 2025 18:08
@github-actions github-actions bot added the binding/rust Issues for the Rust crate label Feb 1, 2025
@alamb alamb marked this pull request as draft February 1, 2025 18:09
@alamb
Copy link
Contributor Author

alamb commented Feb 1, 2025

Yeah, I have this change which I would like to land to also make this easier

Turns out 5c5c65d makes it failry easy

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

Attention: Patch coverage is 37.50000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 71.75%. Comparing base (64cb62d) to head (9aa5a3d).

Files with missing lines Patch % Lines
python/src/filesystem.rs 0.00% 5 Missing ⚠️
python/src/lib.rs 0.00% 4 Missing ⚠️
crates/core/src/writer/json.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3175      +/-   ##
==========================================
- Coverage   71.75%   71.75%   -0.01%     
==========================================
  Files         138      138              
  Lines       44362    44372      +10     
  Branches    44362    44372      +10     
==========================================
+ Hits        31833    31837       +4     
- Misses      10498    10499       +1     
- Partials     2031     2036       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alamb
Copy link
Contributor Author

alamb commented Feb 1, 2025

I would say the tests all look good to me :bowtie: -- there looks to be some error with docs, but that doesn't look like any reason to avoid releasing DataFusion. Otherwise things are looking 👌

@ion-elgreco
Copy link
Collaborator

I would say the tests all look good to me :bowtie: -- there looks to be some error with docs, but that doesn't look like any reason to avoid releasing DataFusion. Otherwise things are looking 👌

Awesome! Thanks @alamb 🙏

@alamb
Copy link
Contributor Author

alamb commented Feb 2, 2025

I would say the tests all look good to me :bowtie: -- there looks to be some error with docs, but that doesn't look like any reason to avoid releasing DataFusion. Otherwise things are looking 👌

Awesome! Thanks @alamb 🙏

Thank you for your patience. BTW I still hope to get the fix for this issue into DataFusion 45 as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package binding/rust Issues for the Rust crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants