Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract all Grades and Averages, fix survey-issue, update pronotepy #102

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vingerha
Copy link
Contributor

Grades and averages are now collected irrespective of the 'period'
Fix information/survey-related error (date vs datetime)
Update to newest pronotepy 2.14.3

for period in client.periods:
for average in period.averages:
if average not in averages:
averages.append(average)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ça veut dire qu'on aurait plusieurs moyennes avec les mêmes noms, il faut peut-être les nommer en fonction de la période ?

Copy link
Contributor Author

@vingerha vingerha Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Le "if average not in averages:" couvre de ne pas avoir des duplicatas. Le code se base sur l'idée que les averages ne changent pas selon la période, donc ils évoluent pendant tout l'année scolaire

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Si j'ajoute la periode, je reviens sur le soucis que j'ai maintenant... des averages que pour semestre 1

Copy link
Contributor Author

@vingerha vingerha Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Salut, mon fils vient de m'informer qu'il attend ces averages commencent de 0 avec la deuxième semestre. Donc il faut attendre un peu pour que je confirme si ça marche ou pas. Sinon je refait le PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants