Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Github Actions #232

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Update Github Actions #232

merged 1 commit into from
Nov 15, 2023

Conversation

chimanjain
Copy link
Contributor

@chimanjain chimanjain commented Nov 15, 2023 •
edited
Loading

Description

Run unit test in GitHub action and update golangci-lint.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1012

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Run GitHub Action

prablr79
prablr79 reviewed Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@prablr79 prablr79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, Hope all test are passing.

@chimanjain
Copy link
Contributor Author

lgtm, Hope all test are passing.

Yes

HarishH-DELL
HarishH-DELL approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@HarishH-DELL HarishH-DELL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

shefali-malhotra
shefali-malhotra approved these changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@shefali-malhotra shefali-malhotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chimanjain chimanjain merged commit 3a90ab7 into main Nov 15, 2023
4 of 5 checks passed
@chimanjain chimanjain deleted the unit-test-gh-action branch November 15, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prablr79 prablr79 prablr79 left review comments

@HarishH-DELL HarishH-DELL HarishH-DELL approved these changes

@shefali-malhotra shefali-malhotra shefali-malhotra approved these changes

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004 bpjain2004 is a code owner

@meggm meggm Awaiting requested review from meggm meggm is a code owner

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108 nitesh3108 is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@Sakshi-dell Sakshi-dell Awaiting requested review from Sakshi-dell Sakshi-dell is a code owner

@santhoshatdell santhoshatdell Awaiting requested review from santhoshatdell santhoshatdell is a code owner

@harshaatdell harshaatdell Awaiting requested review from harshaatdell

@ChristianAtDell ChristianAtDell Awaiting requested review from ChristianAtDell ChristianAtDell is a code owner

@donatwork donatwork Awaiting requested review from donatwork donatwork is a code owner

@adamginna-dell adamginna-dell Awaiting requested review from adamginna-dell

@cbartoszDell cbartoszDell Awaiting requested review from cbartoszDell

@bogdanNovikovDell bogdanNovikovDell Awaiting requested review from bogdanNovikovDell

@Leonard-Dell Leonard-Dell Awaiting requested review from Leonard-Dell

@mtrajfacki-dell mtrajfacki-dell Awaiting requested review from mtrajfacki-dell

@mareksuski-dell mareksuski-dell Awaiting requested review from mareksuski-dell

@shanduur-dell shanduur-dell Awaiting requested review from shanduur-dell

@mdutka-dell mdutka-dell Awaiting requested review from mdutka-dell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chimanjain @prablr79 @shefali-malhotra @HarishH-DELL