feat: adding cache and sync functionality #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
0xJabberwock
suggested changes
Aug 20, 2024
wei3erHase
changed the title
0xJabberwock
approved these changes
Aug 21, 2024
test/e2e/data-receiver.spec.ts
Outdated
Comment on lines
214
to
215
| it('should all the observations when called without max', async () => { | ||
| tx = await dataReceiver.syncObservations(salt, 0); |
There was a problem hiding this comment.
'should add the observations...'
test/e2e/data-receiver.spec.ts
Outdated
Comment on lines
226
to
227
| it('should all observations limited by max argument', async () => { | ||
| tx = await dataReceiver.syncObservations(salt, 2); |
There was a problem hiding this comment.
'should add observations...'
test/unit/DataReceiver.spec.ts
Outdated
Comment on lines
328
to
329
| it('should all observations limited by max argument', async () => { | ||
| tx = await dataReceiver.syncObservations(randomSalt, 2); |
There was a problem hiding this comment.
'should add observations...'
test/unit/DataReceiver.spec.ts
Outdated
Comment on lines
341
to
342
| it('should all the observations when called without max', async () => { | ||
| tx = await dataReceiver.syncObservations(randomSalt, 0); |
There was a problem hiding this comment.
'should add the observations...'
Comment on lines
+357
to
+361
| it.skip('should delete added cache observations', async () => { | ||
| // should sync nonce and nonce + 1 (nonce + 2 should remain in cache) | ||
| await dataReceiver.syncObservations(randomSalt, 2); | ||
|
|
||
| // NOTE: smock having issues with internal mapping structs |
Comment on lines
63
to
64
|
|
||
| /// @notice Allows any address to attemt to insert cached observations |
There was a problem hiding this comment.
Allows any address to attempt to...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.