-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ensure relative timestamps #64
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now `bondDisputeDeadline` is a number of seconds. BondEscalationModule ensures that after the dispute's creation timestamp plus the `bondDisputeDeadline` of the request's parameter certain actions will revert.
0xShaito
reviewed
Oct 8, 2024
0xShaito
reviewed
Oct 8, 2024
0xShaito
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes OPO-650
Esentially this PR changes the definition of some parameters from being a timestamp to be a number of seconds.
This PR will introduce duplicate calls in some modules.
For example the internal function
_validateDispute
inValidator.sol
does the following check:and now some parts of the dispute modules need to query the dispute creation time to verify if a given dispute is within the escalation window. As a result, any function that uses
_validateDispute
and also queries the dispute's creation time will make the same call twice.I
canwill make another PR to fix this problem later.Another thing to consider is
startTime
fromEscalation
struct in IERC20ResolutionModule.This could be redefined as something like "the number of seconds after the creation of the dispute when it was escalated".