fix: ensure input arrays have the same length

defi-wonderland · Dec 10, 2024 · f223864 · f223864
1 parent 3e1078a
commit f223864
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/solidity/contracts/Oracle.sol b/solidity/contracts/Oracle.sol
@@ -111,8 +111,12 @@ contract Oracle is IOracle, OracleAccessController {
     AccessControl[] calldata _accessControl
   ) external returns (bytes32[] memory _batchRequestsIds) {
     uint256 _requestsAmount = _requestsData.length;
-    _batchRequestsIds = new bytes32[](_requestsAmount);
 
+    if (_requestsAmount != _ipfsHashes.length || _requestsAmount != _accessControl.length) {
+      revert Oracle_ArrayMismatchLength();
+    }
+
+    _batchRequestsIds = new bytes32[](_requestsAmount);
     for (uint256 _i; _i < _requestsAmount;) {
       _batchRequestsIds[_i] = _createRequest(_requestsData[_i], _ipfsHashes[_i], _accessControl[_i]);
       unchecked {

diff --git a/solidity/interfaces/IOracle.sol b/solidity/interfaces/IOracle.sol
@@ -168,6 +168,11 @@ interface IOracle is IOracleAccessController {
    */
   error Oracle_InvalidDisputer();
 
+  /**
+   * @notice Thrown when the input arrays have different lengths
+   */
+  error Oracle_ArrayMismatchLength();
+
   /*///////////////////////////////////////////////////////////////
                               ENUMS
   //////////////////////////////////////////////////////////////*/