refactor: ResponseDisputed arguments

defi-wonderland · Nov 6, 2023 · 01089b2 · 01089b2
1 parent 8040b16
commit 01089b2
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 12 deletions.
diff --git a/solidity/contracts/Oracle.sol b/solidity/contracts/Oracle.sol
@@ -184,7 +184,7 @@ contract Oracle is IOracle {
 
     IDisputeModule(_request.disputeModule).disputeResponse(_request, _response, _dispute);
 
-    emit ResponseDisputed(msg.sender, _responseId, _disputeId, _dispute, block.number);
+    emit ResponseDisputed(_responseId, _disputeId, _dispute, block.number);
 
     if (disputeStatus[_disputeId] != DisputeStatus.Active) {
       IDisputeModule(_request.disputeModule).onDisputeStatusChange(_disputeId, _request, _response, _dispute);

diff --git a/solidity/interfaces/IOracle.sol b/solidity/interfaces/IOracle.sol
@@ -27,17 +27,13 @@ interface IOracle {
 
   /**
    * @notice Emitted when a response is disputed
-   * @param _disputer The address of the user who started the dispute
    * @param _responseId The id of the response being disputed
    * @param _disputeId The id of the dispute
-   * @param _blockNumber The block number of the dispute
+   * @param _dispute The dispute that has been created
+   * @param _blockNumber The current block number
    */
   event ResponseDisputed(
-    address indexed _disputer,
-    bytes32 indexed _responseId,
-    bytes32 indexed _disputeId,
-    Dispute _dispute,
-    uint256 _blockNumber
+    bytes32 indexed _responseId, bytes32 indexed _disputeId, Dispute _dispute, uint256 _blockNumber
   );
 
   /**

diff --git a/solidity/interfaces/modules/dispute/IDisputeModule.sol b/solidity/interfaces/modules/dispute/IDisputeModule.sol
@@ -11,12 +11,14 @@ interface IDisputeModule is IModule {
 
   /**
    * @notice Emitted when a response is disputed
-   * @param _requestId The id of the request created
    * @param _responseId The id of the response disputed
-   * @param _disputer The address of the disputed
-   * @param _proposer The address of the proposer
+   * @param _disputeId The id of the dispute
+   * @param _dispute The dispute that is being created
+   * @param _blockNumber The current block number
    */
-  event ResponseDisputed(bytes32 indexed _requestId, bytes32 _responseId, address _disputer, address _proposer);
+  event ResponseDisputed(
+    bytes32 indexed _responseId, bytes32 indexed _disputeId, IOracle.Dispute _dispute, uint256 _blockNumber
+  );
 
   /**
    * @notice Emitted when a dispute status is updated