feat: base processors package #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xkenj1
previously approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Lets add a better description here, giving more detail about the contracts and what should process function does. (Factory+process)
Or should be more abstracted as it is ? wdyt?
There was a problem hiding this comment.
you think Contract should be explained here? I was thinking the latter, a more abstract description. (We can go deeper in readme)
jahabeebs
reviewed
Oct 11, 2024
| @@ -0,0 +1,143 @@ | |||
| import { ChainId } from "@grants-stack-indexer/shared"; | |||
| import { Address } from "@grants-stack-indexer/shared/dist/src/internal.js"; | |||
There was a problem hiding this comment.
did you mean to import this from the dist?
0xkenj1
approved these changes
Oct 11, 2024
jahabeebs
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes GIT-95
Description
processorspackage withIProcessorinterfaceChecklist before requesting a review