Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: checker integration #53

Merged
merged 4 commits into from
Jan 15, 2025
Merged

feat: checker integration #53

merged 4 commits into from
Jan 15, 2025

Conversation

0xkenj1
Copy link
Collaborator

@0xkenj1 0xkenj1 commented Jan 14, 2025

🤖 Linear

Closes GIT-183

Description

Integration between Indexer v2 and checker app

Checklist before requesting a review

  • I have conducted a self-review of my code.
  • I have conducted a QA.
  • If it is a core feature, I have included comprehensive tests.

Copy link

linear bot commented Jan 14, 2025

select *
from ${ref("projects")}
where id = a.project_id
and (chain_id = a.chain_id or true)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the or true correct?

Copy link
Collaborator

@jahabeebs jahabeebs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, maybe just change the PR title to a conventional commit (:

@0xkenj1 0xkenj1 changed the title Feat/checker integration feat: checker integration Jan 15, 2025
Copy link
Collaborator

@0xnigir1 0xnigir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noise

@0xkenj1 0xkenj1 merged commit 0edae83 into dev Jan 15, 2025
6 checks passed
@0xkenj1 0xkenj1 deleted the feat/checker-integration branch January 15, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants