feat: Operator Access Module

[xorsal]

🤖 Linear

Closes GRT-227

[linear]

GRT-227 Create OperatorAccessControl

[0xJabberwock]

HorizonAccountingExtension features an immutable state variable for HorizonStaking, which is inconsistent with how it is treated here.

[xorsal]

I wasn’t aware of IHorizonStakingExtension::HORIZON_STAKING(). I wouldn't say it's inconsistent, it could definitely lead to unexpected behavior if the wrong addresses are set during deployment.

But more importantly, if horizonStaking can be obtained via a call (staticcall?) to horizonAccountingExtension, then I propose removing the horizonStaking state variable and instead calling HorizonStakingExtension::HORIZON_STAKING every time it’s needed, which is only inside of the hasAccess function.

Would this make sense to you?

[0xJabberwock]

Performing an external call ad infinitum to get an immutable variable doesn't make sense to me in terms of gas efficiency, compared to storing it once. The HorizonStaking address could be sent in the constructor or got through a single external call in it—however, this last option requires HorizonAccountingExtension to have been deployed, which might not be desirable.

Beware that HorizonStaking, HorizonStakingExtension and HorizonAccountingExtension refer to different contracts.

[xorsal]

Beware that HorizonStaking, HorizonStakingExtension and HorizonAccountingExtension refer to different contracts.

My bad, I mixed up the contract names.

HorizonAccountingExtension is the one that has the external view HORIZON_STAKING

however, this last option requires HorizonAccountingExtension to have been deployed, which might not be desirable.

The HorizonAccountingExtension should be already deployed when EBOAccessModule is live because it's used in hasAccess to do the isAuthorized call.

And if that isn't the case, the module also have setHorizonAccountingExtension to update its address whenever necessary.

[xorsal]

now whenever the horizonAccountingExtension is updated, it will also call HORIZON_STAKING and update the horizonStaking address.

Relevant changes in: 630ce61